Re: Review Request 60377: Added test for reservation refinements and old agents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60377/#review178756 --- Ship it! Ship It! - Michael Park On June 22, 2017, 2:18 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60377/ > --- > > (Updated June 22, 2017, 2:18 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > If the agent does not support reservation refinements, attempts to > create a reservation refinement on the agent should be dropped by the > master. > > > Diffs > - > > src/tests/upgrade_tests.cpp eef81018ab3fae2e91077d4314cdaba274111401 > > > Diff: https://reviews.apache.org/r/60377/diff/1/ > > > Testing > --- > > `make check`, ran ~5k iterations w/o error. > > > Thanks, > > Neil Conway > >
Re: Review Request 60377: Added test for reservation refinements and old agents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60377/#review178748 --- Bad patch! Reviews applied: [60377, 60374, 60284, 60255, 60283, 60352, 60351, 60282, 60281] Failed command: python support/apply-reviews.py -n -r 60283 Error: error: patch failed: src/master/master.cpp:4605 error: src/master/master.cpp: patch does not apply Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/120/console - Mesos Reviewbot Windows On June 22, 2017, 9:18 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60377/ > --- > > (Updated June 22, 2017, 9:18 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > If the agent does not support reservation refinements, attempts to > create a reservation refinement on the agent should be dropped by the > master. > > > Diffs > - > > src/tests/upgrade_tests.cpp eef81018ab3fae2e91077d4314cdaba274111401 > > > Diff: https://reviews.apache.org/r/60377/diff/1/ > > > Testing > --- > > `make check`, ran ~5k iterations w/o error. > > > Thanks, > > Neil Conway > >
Review Request 60377: Added test for reservation refinements and old agents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60377/ --- Review request for mesos and Michael Park. Repository: mesos Description --- If the agent does not support reservation refinements, attempts to create a reservation refinement on the agent should be dropped by the master. Diffs - src/tests/upgrade_tests.cpp eef81018ab3fae2e91077d4314cdaba274111401 Diff: https://reviews.apache.org/r/60377/diff/1/ Testing --- `make check`, ran ~5k iterations w/o error. Thanks, Neil Conway
