Re: Review Request 60820: Add class definition for SlaveID acceptor.

2017-07-12 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/#review180382
---



Patch looks great!

Reviews applied: [60279, 60716, 60820]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 12, 2017, 11:35 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60820/
> ---
> 
> (Updated July 12, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and 
> Vinod Kone.
> 
> 
> Bugs: MESOS-7630
> https://issues.apache.org/jira/browse/MESOS-7630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add class definition for SlaveID acceptor.
> 
> To resolve the dependency issue (they are correlated
> by SlaveWriter, FrameworkWriter through the /state endpoint)
> between reviews
> https://reviews.apache.org/r/60712/ ,
> https://reviews.apache.org/r/60580/ ,
> https://reviews.apache.org/r/60581/
> these three patches are merged and closed.
> This patch contains the class definition
> for the merged code.
> 
> 
> Diffs
> -
> 
>   src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
>   src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 
> 
> 
> Diff: https://reviews.apache.org/r/60820/diff/1/
> 
> 
> Testing
> ---
> 
> make check -j48
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>



Review Request 60820: Add class definition for SlaveID acceptor.

2017-07-12 Thread Quinn Leng

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60820/
---

Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod 
Kone.


Bugs: MESOS-7630
https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
---

Add class definition for SlaveID acceptor.

To resolve the dependency issue (they are correlated
by SlaveWriter, FrameworkWriter through the /state endpoint)
between reviews
https://reviews.apache.org/r/60712/ ,
https://reviews.apache.org/r/60580/ ,
https://reviews.apache.org/r/60581/
these three patches are merged and closed.
This patch contains the class definition
for the merged code.


Diffs
-

  src/common/http.hpp 93c9b2e58600189867b85175fe4de2dc2f6bf33e 
  src/common/http.cpp 7dce4cdc82a64702431bbc4307757ec797cf4309 


Diff: https://reviews.apache.org/r/60820/diff/1/


Testing
---

make check -j48


Thanks,

Quinn Leng