Re: Review Request 60877: Improved calculation of resource limits for containerizer.

2017-07-14 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60877/#review180631
---



Patch looks great!

Reviews applied: [60867, 60636, 60369, 60539, 60370, 60876, 60877]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 14, 2017, 11:56 a.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60877/
> ---
> 
> (Updated July 14, 2017, 11:56 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Included resources of executor's pending tasks in calculation of
> resource limits for containerizer after status update.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 64d24113a1c29a6a9b8401151e6a9fd92511ae40 
> 
> 
> Diff: https://reviews.apache.org/r/60877/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Re: Review Request 60877: Improved calculation of resource limits for containerizer.

2017-07-14 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60877/#review180576
---



Patch looks great!

Reviews applied: [60867, 60636, 60369, 60539, 60370, 60876, 60877]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 14, 2017, 6:56 p.m., Andrei Budnik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60877/
> ---
> 
> (Updated July 14, 2017, 6:56 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
> https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Included resources of executor's pending tasks in calculation of
> resource limits for containerizer after status update.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp 64d24113a1c29a6a9b8401151e6a9fd92511ae40 
> 
> 
> Diff: https://reviews.apache.org/r/60877/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>



Review Request 60877: Improved calculation of resource limits for containerizer.

2017-07-14 Thread Andrei Budnik

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60877/
---

Review request for mesos, Benjamin Mahler and haosdent huang.


Bugs: MESOS-6441
https://issues.apache.org/jira/browse/MESOS-6441


Repository: mesos


Description
---

Included resources of executor's pending tasks in calculation of
resource limits for containerizer after status update.


Diffs
-

  src/slave/slave.cpp 64d24113a1c29a6a9b8401151e6a9fd92511ae40 


Diff: https://reviews.apache.org/r/60877/diff/1/


Testing
---

sudo make check (mac os x, fedora 25)


Thanks,

Andrei Budnik