Re: Review Request 60931: Added test cases for framework streaming events.

2017-08-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review182292
---



Patch looks great!

Reviews applied: [60928, 60929, 60930, 60931]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 27, 2017, 6:24 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 27, 2017, 6:24 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/5/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-27 Thread Quinn Leng 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/
---

(Updated July 27, 2017, 6:24 p.m.)


Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.


Bugs: MESOS-6101
https://issues.apache.org/jira/browse/MESOS-6101


Repository: mesos


Description
---

Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
'FRAMEWORK_REMOVED' events in v1 operator API.


Diffs (updated)
-

  src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 


Diff: https://reviews.apache.org/r/60931/diff/4/

Changes: https://reviews.apache.org/r/60931/diff/3-4/


Testing
---

make check


Thanks,

Quinn Leng

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-27 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181586
---


Fix it, then Ship it!




Just some minor nits to fix.


src/tests/api_tests.cpp
Lines 1977 (patched)


s/, as a result, the/. The



src/tests/api_tests.cpp
Lines 1982-1986 (patched)


Move this before L2007 to be close to where its used.



src/tests/api_tests.cpp
Lines 1984 (patched)


s/to be a/to a



src/tests/api_tests.cpp
Lines 1986 (patched)


Can we just use `Weeks(2)` here instead of the magic number



src/tests/api_tests.cpp
Lines 2082 (patched)


s/As a result, the/The


- Anand Mazumdar


On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 18, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-25 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181404
---



Patch looks great!

Reviews applied: [60928, 60929, 60930, 60931]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 17, 2017, 5:29 p.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 17, 2017, 5:29 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181277
---



Patch looks great!

Reviews applied: [60928, 60929, 60930, 60931]

Passed command: support\windows-build.bat

- Mesos Reviewbot Windows


On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 18, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-24 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181254
---



Mostly some comments around using the `/teardown` endpoint to trigger the 
`FRAMEWORK_REMOVED` event. It's mostly due to the fact that we don't yet 
support updating `FrameworkInfo` for some fields due to 
https://issues.apache.org/jira/browse/MESOS-703 (and is not supported well).


src/tests/api_tests.cpp
Lines 1925-1927 (patched)


s/is able/can to be consistent with the agent test.



src/tests/api_tests.cpp
Lines 1935 (patched)


Kill this comment; its self-explanatory.



src/tests/api_tests.cpp
Lines 1963 (patched)


Kill this.



src/tests/api_tests.cpp
Lines 1979 (patched)


How about:

```cpp
// Start a scheduler. The subscriber should receive a `FRAMEWORK_ADDED` 
event when the scheduler subscribes with the master.
```



src/tests/api_tests.cpp
Lines 1985-1987 (patched)


hmm, can you just set this to a larger value (ideally a week) since the 
framework can be removed due to the failover timeout happening upon a 
disconnection!



src/tests/api_tests.cpp
Lines 1992 (patched)


Why do you need the `WillRepeatedly` here?



src/tests/api_tests.cpp
Lines 2009-2010 (patched)


Kill this; since we included the info above.



src/tests/api_tests.cpp
Lines 2050 (patched)


How about:

```cpp
Force a reconnection with the master. This should result in a 
`FRAMEWORK_UPDATED` event when the scheduler re-registers with the master.
```



src/tests/api_tests.cpp
Lines 2060-2062 (patched)


Kill this. Let's send a request to the `/teardown` endpoint to tear-down 
the framework and use that to verify the `FRAMEWORK_REMOVED` event.


- Anand Mazumdar


On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 18, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>

Re: Review Request 60931: Added test cases for framework streaming events.

2017-07-20 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60931/#review181053
---



Patch looks great!

Reviews applied: [60928, 60929, 60930, 60931]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker-build.sh

- Mesos Reviewbot


On July 18, 2017, 12:29 a.m., Quinn Leng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60931/
> ---
> 
> (Updated July 18, 2017, 12:29 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li.
> 
> 
> Bugs: MESOS-6101
> https://issues.apache.org/jira/browse/MESOS-6101
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test cases for 'FRAMEWORK_ADDED', 'FRAMEWORK_UPDATED' and
> 'FRAMEWORK_REMOVED' events in v1 operator API.
> 
> 
> Diffs
> -
> 
>   src/tests/api_tests.cpp f22ca28c819712d8797e0c0c69dc1ebf1fe5ac1f 
> 
> 
> Diff: https://reviews.apache.org/r/60931/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Quinn Leng
> 
>