Re: Review Request 61057: Removed ProcessBase::inject to support future event queues.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61057/#review181413
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/event.hpp
Lines 199-200 (original), 199-200 (patched)


Could you clarify in the commit description that we continue to support 
injection for termination events only?



3rdparty/libprocess/src/process.cpp
Lines 3234 (patched)


This is written a bit oddly, since it seems to suggest that terminate may 
change during the loop, maybe just use an if?


- Benjamin Mahler


On July 24, 2017, 1:46 a.m., Benjamin Hindman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61057/
> ---
> 
> (Updated July 24, 2017, 1:46 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7798
> https://issues.apache.org/jira/browse/MESOS-7798
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed ProcessBase::inject to support future event queues.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/event.hpp 
> a0ec05380066e1065af2d9da3c920c8a786b6f06 
>   3rdparty/libprocess/include/process/process.hpp 
> d40179f874754e00b58f271c401650138dc7d01c 
>   3rdparty/libprocess/src/process.cpp 
> b268cdad776a3ca2a87cbe60eb098bde2a70667c 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> ed11909a2a5e3214fa974bdea098f4057cea9666 
> 
> 
> Diff: https://reviews.apache.org/r/61057/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Review Request 61057: Removed ProcessBase::inject to support future event queues.

[Benjamin Hindman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61057/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7798
https://issues.apache.org/jira/browse/MESOS-7798


Repository: mesos


Description
---

Removed ProcessBase::inject to support future event queues.


Diffs
-

  3rdparty/libprocess/include/process/event.hpp 
a0ec05380066e1065af2d9da3c920c8a786b6f06 
  3rdparty/libprocess/include/process/process.hpp 
d40179f874754e00b58f271c401650138dc7d01c 
  3rdparty/libprocess/src/process.cpp b268cdad776a3ca2a87cbe60eb098bde2a70667c 
  3rdparty/libprocess/src/tests/process_tests.cpp 
ed11909a2a5e3214fa974bdea098f4057cea9666 


Diff: https://reviews.apache.org/r/61057/diff/1/


Testing
---

make check


Thanks,

Benjamin Hindman