Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

[Qian Zhang]

> On Aug. 8, 2017, 8:05 a.m., Gastón Kleiman wrote:
> > src/tests/containerizer/isolator_tests.cpp
> > Line 176 (original), 176 (patched)
> > 
> >
> > `/proc/self/ns/ipc` is also a symlink, should we change this line too?

Good catch!


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182344
---


On Aug. 7, 2017, 11:12 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61463/
> ---
> 
> (Updated Aug. 7, 2017, 11:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this test, we used the command `stat -c %i /proc/self/ns/pid` to
> get the current process's pid namespace inode, that is not correct
> since `/proc/self/ns/pid` is a symbol link, we should get the inode
> that the link references rather than the link itself. So we need to
> add a `-L` option in the `stat` command.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> f3c541c92f8ecc5c12356363bbbf3561d3b75230 
> 
> 
> Diff: https://reviews.apache.org/r/61463/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182344
---


Fix it, then Ship it!





src/tests/containerizer/isolator_tests.cpp
Line 176 (original), 176 (patched)


`/proc/self/ns/ipc` is also a symlink, should we change this line too?


- Gastón Kleiman


On Aug. 7, 2017, 3:12 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61463/
> ---
> 
> (Updated Aug. 7, 2017, 3:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this test, we used the command `stat -c %i /proc/self/ns/pid` to
> get the current process's pid namespace inode, that is not correct
> since `/proc/self/ns/pid` is a symbol link, we should get the inode
> that the link references rather than the link itself. So we need to
> add a `-L` option in the `stat` command.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> f3c541c92f8ecc5c12356363bbbf3561d3b75230 
> 
> 
> Diff: https://reviews.apache.org/r/61463/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/#review182343
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 7, 2017, 8:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61463/
> ---
> 
> (Updated Aug. 7, 2017, 8:12 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
> and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In this test, we used the command `stat -c %i /proc/self/ns/pid` to
> get the current process's pid namespace inode, that is not correct
> since `/proc/self/ns/pid` is a symbol link, we should get the inode
> that the link references rather than the link itself. So we need to
> add a `-L` option in the `stat` command.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/isolator_tests.cpp 
> f3c541c92f8ecc5c12356363bbbf3561d3b75230 
> 
> 
> Diff: https://reviews.apache.org/r/61463/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Review Request 61463: Fixed a bug in the test `NamespacesIsolatorTest.ROOT_PidNamespace`.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61463/
---

Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
and Vinod Kone.


Repository: mesos


Description
---

In this test, we used the command `stat -c %i /proc/self/ns/pid` to
get the current process's pid namespace inode, that is not correct
since `/proc/self/ns/pid` is a symbol link, we should get the inode
that the link references rather than the link itself. So we need to
add a `-L` option in the `stat` command.


Diffs
-

  src/tests/containerizer/isolator_tests.cpp 
f3c541c92f8ecc5c12356363bbbf3561d3b75230 


Diff: https://reviews.apache.org/r/61463/diff/1/


Testing
---


Thanks,

Qian Zhang