Re: Review Request 62893: Expand description of the --recovery_timeout flag.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/#review190806
---


Ship it!




Ship It!

- Alexander Rukletsov


On Nov. 10, 2017, 3:45 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62893/
> ---
> 
> (Updated Nov. 10, 2017, 3:45 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expand description of the --recovery_timeout flag.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp c5078a85f4d3b30ffd8a9fcc1fbb87980d7d2a03 
> 
> 
> Diff: https://reviews.apache.org/r/62893/diff/2/
> 
> 
> Testing
> ---
> 
> No.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/#review190752
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['62893']`

Failed command: 
`C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62893

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62893/logs/libprocess-tests-stdout.log):

```
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/0 (873 ms)
[ RUN  ] Scheme/HTTPTest.WWWAuthenticateHeader/1
[   OK ] Scheme/HTTPTest.WWWAuthenticateHeader/1 (69 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/0
[   OK ] Scheme/HTTPTest.Accepts/0 (701 ms)
[ RUN  ] Scheme/HTTPTest.Accepts/1
[   OK ] Scheme/HTTPTest.Accepts/1 (87 ms)
[--] 34 tests from Scheme/HTTPTest (14705 ms total)

[--] 4 tests from SSLVerifyIPAdd/SSLTest
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/0 (657 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1
[   OK ] SSLVerifyIPAdd/SSLTest.BasicSameProcess/1 (646 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (1518 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1 (1272 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (4219 ms total)

[--] Global test environment tear-down
[==] 201 tests from 33 test cases ran. (45792 ms total)
[  PASSED  ] 200 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLTest.ProtocolMismatch

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62893/logs/libprocess-tests-stderr.log):

```
I1110 22:34:02.101291  3240 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\dY7JZ0\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1110 22:34:03.331064  4156 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 22:34:03.332064  4156 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 22:34:03.333065  4156 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1110 22:34:03.333065  4156 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 22:34:03.333065  4156 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\NKNr6L\cert.pem
ble peer certificate verification
I1110 22:34:00.605799  4648 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1110 22:34:00.606910  4648 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 22:34:00.606910  4648 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\wtJbrh\cert.pem
I1110 22:34:00.607800  4648 openssl.cpp:566] Using CA dir: 
C:\Users\mesos\AppData\Local\Temp\wtJbrh
I1110 22:34:01.791285  4648 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 22:34:01.791285  4648 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 22:34:01.791285  4648 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 22:34:01.792285  4648 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\dY7JZ0\cert.pem
I1110 22:34:03.023057  4648 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 22:34:03.023057  4648 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 22:34:03.023057  4648 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1110 22:34:03.023057  4648 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 22:34:03.024057  4648 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\NKNr6L\cert.pem
I1110 22:34:03.588218  3248 process.cpp:1052] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Nov. 10, 2017, 3:45 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> 

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/
---

(Updated Nov. 10, 2017, 3:45 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Expand description of the --recovery_timeout flag.


Diffs
-

  src/slave/flags.cpp c5078a85f4d3b30ffd8a9fcc1fbb87980d7d2a03 


Diff: https://reviews.apache.org/r/62893/diff/2/


Testing (updated)
---

No.


Thanks,

Benno Evers

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/#review187679
---



PASS: Mesos patch 62893 was successfully built and tested.

Reviews applied: `['62893']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62893

- Mesos Reviewbot Windows


On Oct. 11, 2017, 2:11 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62893/
> ---
> 
> (Updated Oct. 11, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expand description of the --recovery_timeout flag.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp d424ade99bccde0c4c4fb591c8a443ccb8fd58ed 
> 
> 
> Diff: https://reviews.apache.org/r/62893/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62893: Expand description of the --recovery_timeout flag.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/#review187674
---




src/slave/flags.cpp
Lines 454-457 (patched)


Agree that it should be close, but disagree about the waste. The timer for 
`agent_reregister_timeout` only running when the master is running. In a 
situation when the master is down (due to a severe outage for example), the 
agent reregister timer is not running, hence it might make sense to have 
`recovery_timeout` longer than `agent_reregister_timeout`.


- Alexander Rukletsov


On Oct. 11, 2017, 2:11 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62893/
> ---
> 
> (Updated Oct. 11, 2017, 2:11 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Expand description of the --recovery_timeout flag.
> 
> 
> Diffs
> -
> 
>   src/slave/flags.cpp d424ade99bccde0c4c4fb591c8a443ccb8fd58ed 
> 
> 
> Diff: https://reviews.apache.org/r/62893/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Review Request 62893: Expand description of the --recovery_timeout flag.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62893/
---

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
---

Expand description of the --recovery_timeout flag.


Diffs
-

  src/slave/flags.cpp d424ade99bccde0c4c4fb591c8a443ccb8fd58ed 


Diff: https://reviews.apache.org/r/62893/diff/1/


Testing
---


Thanks,

Benno Evers