Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/ --- (Updated Nov. 13, 2017, 8:20 p.m.) Review request for mesos, Alexander Rukletsov and Jie Yu. Bugs: MESOS-8123 https://issues.apache.org/jira/browse/MESOS-8123 Repository: mesos Description --- This set of tests was broken because they didn't expect the TASK_STARTING update from the executor. Diffs - src/tests/containerizer/nvidia_gpu_isolator_tests.cpp b97b9a41b5b3ac042b72689c49933a225a4c2b9a Diff: https://reviews.apache.org/r/63214/diff/2/ Testing --- `sudo ./mesos-tests --gtest_filter="*GPU*" --gtest_repeat=5` on `core-dev`. Thanks, Benno Evers
Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/#review188976 --- PASS: Mesos patch 63214 was successfully built and tested. Reviews applied: `['63214']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63214 - Mesos Reviewbot Windows On Oct. 23, 2017, 4:51 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63214/ > --- > > (Updated Oct. 23, 2017, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Repository: mesos > > > Description > --- > > This set of tests was broken because they didn't expect the > TASK_STARTING update from the executor. > > > Diffs > - > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > b97b9a41b5b3ac042b72689c49933a225a4c2b9a > > > Diff: https://reviews.apache.org/r/63214/diff/2/ > > > Testing > --- > > `sudo ./mesos-tests --gtest_filter="*GPU*" --gtest_repeat=5` on `core-dev`. > > > Thanks, > > Benno Evers > >
Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/#review188960 --- Ship it! Ship It! - Jie Yu On Oct. 23, 2017, 4:51 p.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63214/ > --- > > (Updated Oct. 23, 2017, 4:51 p.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Repository: mesos > > > Description > --- > > This set of tests was broken because they didn't expect the > TASK_STARTING update from the executor. > > > Diffs > - > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > b97b9a41b5b3ac042b72689c49933a225a4c2b9a > > > Diff: https://reviews.apache.org/r/63214/diff/2/ > > > Testing > --- > > `sudo ./mesos-tests --gtest_filter="*GPU*" --gtest_repeat=5` on `core-dev`. > > > Thanks, > > Benno Evers > >
Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/ --- (Updated Oct. 23, 2017, 4:51 p.m.) Review request for mesos, Alexander Rukletsov and Jie Yu. Changes --- Update and actually test the changes. Repository: mesos Description --- This set of tests was broken because they didn't expect the TASK_STARTING update from the executor. Diffs (updated) - src/tests/containerizer/nvidia_gpu_isolator_tests.cpp b97b9a41b5b3ac042b72689c49933a225a4c2b9a Diff: https://reviews.apache.org/r/63214/diff/2/ Changes: https://reviews.apache.org/r/63214/diff/1-2/ Testing (updated) --- `sudo ./mesos-tests --gtest_filter="*GPU*" --gtest_repeat=5` on `core-dev`. Thanks, Benno Evers
Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/#review188934 --- PASS: Mesos patch 63214 was successfully built and tested. Reviews applied: `['63214']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63214 - Mesos Reviewbot Windows On Oct. 23, 2017, 10:20 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63214/ > --- > > (Updated Oct. 23, 2017, 10:20 a.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Repository: mesos > > > Description > --- > > This set of tests was broken because they didn't expect the > TASK_STARTING update from the executor. > > > Diffs > - > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > b97b9a41b5b3ac042b72689c49933a225a4c2b9a > > > Diff: https://reviews.apache.org/r/63214/diff/1/ > > > Testing > --- > > I'm actually not sure where I can test these changes. > > > Thanks, > > Benno Evers > >
Re: Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/#review188932 --- Patch looks great! Reviews applied: [63214] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 23, 2017, 10:20 a.m., Benno Evers wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63214/ > --- > > (Updated Oct. 23, 2017, 10:20 a.m.) > > > Review request for mesos, Alexander Rukletsov and Jie Yu. > > > Repository: mesos > > > Description > --- > > This set of tests was broken because they didn't expect the > TASK_STARTING update from the executor. > > > Diffs > - > > src/tests/containerizer/nvidia_gpu_isolator_tests.cpp > b97b9a41b5b3ac042b72689c49933a225a4c2b9a > > > Diff: https://reviews.apache.org/r/63214/diff/1/ > > > Testing > --- > > I'm actually not sure where I can test these changes. > > > Thanks, > > Benno Evers > >
Review Request 63214: Fixed GPU tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63214/ --- Review request for mesos, Alexander Rukletsov and Jie Yu. Repository: mesos Description --- This set of tests was broken because they didn't expect the TASK_STARTING update from the executor. Diffs - src/tests/containerizer/nvidia_gpu_isolator_tests.cpp b97b9a41b5b3ac042b72689c49933a225a4c2b9a Diff: https://reviews.apache.org/r/63214/diff/1/ Testing --- Thanks, Benno Evers
