Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-26 Thread Raluca Miclea 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/
---

(Updated Oct. 26, 2017, 11:01 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Changes
---

removed TODO comments


Bugs: MESOS-3437
https://issues.apache.org/jira/browse/MESOS-3437


Repository: mesos


Description
---

They worked out of the box.
Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests to 
fail were solved.


Diffs (updated)
-

  3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 


Diff: https://reviews.apache.org/r/63239/diff/2/

Changes: https://reviews.apache.org/r/63239/diff/1-2/


Testing
---

Modified Tests:
TEST(FlagsTest, LoadFromEnvironment)
TEST(FlagsTest, DuplicatesFromEnvironment)


Thanks,

Raluca Miclea

Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-24 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/#review189072
---




3rdparty/stout/tests/flags_tests.cpp
Lines 229-231 (original), 229-231 (patched)


If it works out of the box now, this comment should be removed.



3rdparty/stout/tests/flags_tests.cpp
Lines 527-528 (original), 527-528 (patched)


Ditto.


- Andrew Schwartzmeyer


On Oct. 24, 2017, 12:57 a.m., Raluca Miclea wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63239/
> ---
> 
> (Updated Oct. 24, 2017, 12:57 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-3437
> https://issues.apache.org/jira/browse/MESOS-3437
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> They worked out of the box.
> Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests 
> to fail were solved.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/flags_tests.cpp 
> 88c8ee57c2bf328251513761498ef98d774be006 
> 
> 
> Diff: https://reviews.apache.org/r/63239/diff/1/
> 
> 
> Testing
> ---
> 
> Modified Tests:
> TEST(FlagsTest, LoadFromEnvironment)
> TEST(FlagsTest, DuplicatesFromEnvironment)
> 
> 
> Thanks,
> 
> Raluca Miclea
> 
>

Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-24 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/#review189036
---



PASS: Mesos patch 63239 was successfully built and tested.

Reviews applied: `['63239']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63239

- Mesos Reviewbot Windows


On Oct. 24, 2017, 7:57 a.m., Raluca Miclea wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63239/
> ---
> 
> (Updated Oct. 24, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-3437
> https://issues.apache.org/jira/browse/MESOS-3437
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> They worked out of the box.
> Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests 
> to fail were solved.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/flags_tests.cpp 
> 88c8ee57c2bf328251513761498ef98d774be006 
> 
> 
> Diff: https://reviews.apache.org/r/63239/diff/1/
> 
> 
> Testing
> ---
> 
> Modified Tests:
> TEST(FlagsTest, LoadFromEnvironment)
> TEST(FlagsTest, DuplicatesFromEnvironment)
> 
> 
> Thanks,
> 
> Raluca Miclea
> 
>

Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-24 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/#review189034
---



Patch looks great!

Reviews applied: [63239]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 24, 2017, 7:57 a.m., Raluca Miclea wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63239/
> ---
> 
> (Updated Oct. 24, 2017, 7:57 a.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-3437
> https://issues.apache.org/jira/browse/MESOS-3437
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> They worked out of the box.
> Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests 
> to fail were solved.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/tests/flags_tests.cpp 
> 88c8ee57c2bf328251513761498ef98d774be006 
> 
> 
> Diff: https://reviews.apache.org/r/63239/diff/1/
> 
> 
> Testing
> ---
> 
> Modified Tests:
> TEST(FlagsTest, LoadFromEnvironment)
> TEST(FlagsTest, DuplicatesFromEnvironment)
> 
> 
> Thanks,
> 
> Raluca Miclea
> 
>

Re: Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-24 Thread Raluca Miclea 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/
---

(Updated Oct. 24, 2017, 7:57 a.m.)


Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-3437
https://issues.apache.org/jira/browse/MESOS-3437


Repository: mesos


Description
---

They worked out of the box.
Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests to 
fail were solved.


Diffs
-

  3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 


Diff: https://reviews.apache.org/r/63239/diff/1/


Testing (updated)
---

Modified Tests:
TEST(FlagsTest, LoadFromEnvironment)
TEST(FlagsTest, DuplicatesFromEnvironment)


Thanks,

Raluca Miclea

Review Request 63239: Ported and enabled Flag Tests on Windows.

2017-10-24 Thread Raluca Miclea 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63239/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-3437
https://issues.apache.org/jira/browse/MESOS-3437


Repository: mesos


Description
---

They worked out of the box.
Apparently the issues MESOS-5880 and MESOS-5937 which were causing the tests to 
fail were solved.


Diffs
-

  3rdparty/stout/tests/flags_tests.cpp 88c8ee57c2bf328251513761498ef98d774be006 


Diff: https://reviews.apache.org/r/63239/diff/1/


Testing
---


Thanks,

Raluca Miclea