Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

2017-11-07 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63606/#review190344
---



PASS: Mesos patch 63606 was successfully built and tested.

Reviews applied: `['63604', '63605', '63606']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63606

- Mesos Reviewbot Windows


On Nov. 7, 2017, 4:23 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63606/
> ---
> 
> (Updated Nov. 7, 2017, 4:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> fe152f273332470ac50f9715291897bb04cf95b9 
> 
> 
> Diff: https://reviews.apache.org/r/63606/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

2017-11-07 Thread Benjamin Hindman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63606/#review190319
---


Ship it!




Ship It!

- Benjamin Hindman


On Nov. 7, 2017, 4:23 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63606/
> ---
> 
> (Updated Nov. 7, 2017, 4:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> fe152f273332470ac50f9715291897bb04cf95b9 
> 
> 
> Diff: https://reviews.apache.org/r/63606/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Re: Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

2017-11-07 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63606/#review190279
---



Patch looks great!

Reviews applied: [63604, 63605, 63606]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Nov. 6, 2017, 8:23 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63606/
> ---
> 
> (Updated Nov. 6, 2017, 8:23 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jiang Yan Xu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/protobuf.hpp 
> fe152f273332470ac50f9715291897bb04cf95b9 
> 
> 
> Diff: https://reviews.apache.org/r/63606/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>



Review Request 63606: Avoid an extra copy during ProtobufProcess::send.

2017-11-06 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63606/
---

Review request for mesos, Benjamin Hindman and Jiang Yan Xu.


Repository: mesos


Description
---

See summary.


Diffs
-

  3rdparty/libprocess/include/process/protobuf.hpp 
fe152f273332470ac50f9715291897bb04cf95b9 


Diff: https://reviews.apache.org/r/63606/diff/1/


Testing
---

make check


Thanks,

Benjamin Mahler