Re: Review Request 63632: Migrated to event consumer interface.

2017-12-05 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63632/
---

(Updated Dec. 5, 2017, 1:50 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Migrated to event consumer interface.


Diffs (updated)
-

  src/common/recordio.hpp 378363492e04c141671fbed0467bf558b61e5dae 
  src/master/master.hpp 448be3b4a3eb3d0cbd34a39b19640d15cf3fc2af 
  src/master/master.cpp 31991b5f7f7f4e7dc73d71a3160348bfc0a627c3 
  src/tests/fetcher_cache_tests.cpp e2ecb102e2e7b4c4b3b2b736fdc453feeb15816e 


Diff: https://reviews.apache.org/r/63632/diff/2/

Changes: https://reviews.apache.org/r/63632/diff/1-2/


Testing
---

make check


Thanks,

Dmitry Zhuk

Re: Review Request 63632: Migrated to event consumer interface.

2017-12-01 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63632/#review192515
---


Fix it, then Ship it!





src/master/master.hpp
Line 548 (original), 548 (patched)


Can we remove the `virtual`s here similar to the libprocess patch?



src/master/master.cpp
Lines 1619 (patched)


I think the `TODO` is sufficient as breadcrumb
for us to know that we need to change code here.

No need to make an extra copy of `MessageEvent`,
here and below.


- Michael Park


On Nov. 7, 2017, 8:51 a.m., Dmitry Zhuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63632/
> ---
> 
> (Updated Nov. 7, 2017, 8:51 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
> https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Migrated to event consumer interface.
> 
> 
> Diffs
> -
> 
>   src/common/recordio.hpp 378363492e04c141671fbed0467bf558b61e5dae 
>   src/master/master.hpp 0c1253aa1a88d113d42ce362d6992ad84217728c 
>   src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
>   src/tests/fetcher_cache_tests.cpp e2ecb102e2e7b4c4b3b2b736fdc453feeb15816e 
> 
> 
> Diff: https://reviews.apache.org/r/63632/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>

Review Request 63632: Migrated to event consumer interface.

2017-11-07 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63632/
---

Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Migrated to event consumer interface.


Diffs
-

  src/common/recordio.hpp 378363492e04c141671fbed0467bf558b61e5dae 
  src/master/master.hpp 0c1253aa1a88d113d42ce362d6992ad84217728c 
  src/master/master.cpp ee212c1a21b432d3aa8e90d748d12cb0a754d57c 
  src/tests/fetcher_cache_tests.cpp e2ecb102e2e7b4c4b3b2b736fdc453feeb15816e 


Diff: https://reviews.apache.org/r/63632/diff/1/


Testing
---

make check


Thanks,

Dmitry Zhuk