Re: Review Request 63636: Added placeholder implementation.

2017-12-05 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63636/
---

(Updated Dec. 5, 2017, 7:21 a.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Added placeholder implementation.


Diffs
-

  3rdparty/stout/include/stout/lambda.hpp 
a61d97b69e7eebd057c94148d39c6e1fc3066017 


Diff: https://reviews.apache.org/r/63636/diff/4/


Testing
---


Thanks,

Dmitry Zhuk

Re: Review Request 63636: Added placeholder implementation.

2017-12-01 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63636/#review192518
---


Fix it, then Ship it!





3rdparty/stout/include/stout/lambda.hpp
Lines 474-476 (patched)


We should inherit from `lambda::Placeholder` here,
`is_placeholder` is expected to provide `::value` for example.



3rdparty/stout/include/stout/lambda.hpp
Lines 479-481 (patched)


We shouldn't need this one.


- Michael Park


On Nov. 22, 2017, 6:13 a.m., Dmitry Zhuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63636/
> ---
> 
> (Updated Nov. 22, 2017, 6:13 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Michael Park.
> 
> 
> Bugs: MESOS-6972
> https://issues.apache.org/jira/browse/MESOS-6972
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added placeholder implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/stout/lambda.hpp 
> a61d97b69e7eebd057c94148d39c6e1fc3066017 
> 
> 
> Diff: https://reviews.apache.org/r/63636/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Dmitry Zhuk
> 
>

Re: Review Request 63636: Added placeholder implementation.

2017-11-22 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63636/
---

(Updated Nov. 22, 2017, 2:13 p.m.)


Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Added placeholder implementation.


Diffs (updated)
-

  3rdparty/stout/include/stout/lambda.hpp 
a61d97b69e7eebd057c94148d39c6e1fc3066017 


Diff: https://reviews.apache.org/r/63636/diff/2/

Changes: https://reviews.apache.org/r/63636/diff/1-2/


Testing
---


Thanks,

Dmitry Zhuk

Review Request 63636: Added placeholder implementation.

2017-11-07 Thread Dmitry Zhuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63636/
---

Review request for mesos, Benjamin Mahler and Michael Park.


Bugs: MESOS-6972
https://issues.apache.org/jira/browse/MESOS-6972


Repository: mesos


Description
---

Added placeholder implementation.


Diffs
-

  3rdparty/stout/include/stout/lambda.hpp 
a61d97b69e7eebd057c94148d39c6e1fc3066017 


Diff: https://reviews.apache.org/r/63636/diff/1/


Testing
---


Thanks,

Dmitry Zhuk