Re: Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

2017-11-13 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63710/#review190830
---


Ship it!




Ship It!

- James Peach


On Nov. 9, 2017, 11:45 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63710/
> ---
> 
> (Updated Nov. 9, 2017, 11:45 p.m.)
> 
> 
> Review request for mesos and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-7519
> https://issues.apache.org/jira/browse/MESOS-7519
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This is addendum to review https://reviews.apache.org/r/55893/.
> The loop that merges outstanding offers can miss some because it
> removes the items from the collection it iterates over.
> 
> 
> Diffs
> -
> 
>   src/tests/oversubscription_tests.cpp 
> d262bbe06787f70427f4f7820e64891c7d1b5552 
> 
> 
> Diff: https://reviews.apache.org/r/63710/diff/1/
> 
> 
> Testing
> ---
> 
> `GLOG_v=2 GTEST_FILTER="*RescindRevocableOfferWithIncreasedRevocable*" 
> ./bin/mesos-tests.sh --verbose --gtest_repeat=1000 --gtest_break_on_failure` 
> on Mac OS 10.11.6
> does not fail with the patch while consistently fails without.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

2017-11-09 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63710/#review190661
---



FAIL: Some Mesos libprocess-tests failed.

Reviews applied: `['63710']`

Failed command: 
`C:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63710

Relevant logs:

- 
[libprocess-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63710/logs/libprocess-tests-stdout.log):

```
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0
[   OK ] SSLVerifyIPAdd/SSLTest.RequireCertificate/0 (693 ms)
[ RUN  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1
C:\DCOS\mesos\mesos\3rdparty\libprocess\src\tests\ssl_tests.cpp(446): error: 
(await_subprocess(client.get(), 0)).failure(): 
[++] Subprocess output.
[==] Running 1 test from 1 test case.

[--] Global test environment set-up.

[--] 1 test from SSLClientTest

[ RUN  ] SSLClientTest.client

[   OK ] SSLClientTest.client (20 ms)

[--] 1 test from SSLClientTest (20 ms total)



[--] Global test environment tear-down

[==] 1 test from 1 test case ran. (20 ms total)

[  PASSED  ] 1 test.

[++]

[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = 
"true" (1301 ms)
[--] 4 tests from SSLVerifyIPAdd/SSLTest (3909 ms total)

[--] Global test environment tear-down
[==] 201 tests from 33 test cases ran. (50027 ms total)
[  PASSED  ] 200 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] SSLVerifyIPAdd/SSLTest.RequireCertificate/1, where GetParam() = 
"true"

 1 FAILED TEST
  YOU HAVE 19 DISABLED TESTS

```

- 
[libprocess-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63710/logs/libprocess-tests-stderr.log):

```
I1110 01:19:35.967464  5712 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 01:19:35.967944  5712 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peWARNING: Logging before 
InitGoogleLogging() is written to STDERR
I1110 01:19:36.268970  1656 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 01:19:36.272972  1656 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 01:19:36.273988  1656 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 01:19:36.273988  1656 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\jaJGI6\cert.pem
WARNING: Logging before InitGoogleLogging() is written to STDERR
I1110 01:19:37.549018  1860 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 01:19:37.550124  1860 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 01:19:37.550124  1860 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1110 01:19:37.551043  1860 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 01:19:37.551043  1860 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\Rw0QU7\cert.pem
er certificate verification
I1110 01:19:35.975944  5712 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 01:19:35.976944  5712 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\jaJGI6\cert.pem
I1110 01:19:37.248008  5712 openssl.cpp:509] CA directory path unspecified! 
NOTE: Set CA directory path with LIBPROCESS_SSL_CA_DIR=
I1110 01:19:37.249007  5712 openssl.cpp:514] Will not verify peer certificate!
NOTE: Set LIBPROCESS_SSL_VERIFY_CERT=1 to enable peer certificate verification
I1110 01:19:37.249007  5712 openssl.cpp:526] Will use IP address verification 
in subject alternative name certificate extension.
I1110 01:19:37.249007  5712 openssl.cpp:534] LIBPROCESS_SSL_REQUIRE_CERT 
implies peer certificate verification.
LIBPROCESS_SSL_VERIFY_CERT set to true
I1110 01:19:37.249007  5712 openssl.cpp:563] Using CA file: 
C:\Users\mesos\AppData\Local\Temp\Rw0QU7\cert.pem
I1110 01:19:37.791163  4256 process.cpp:1052] Failed to accept socket: future 
discarded
```

- Mesos Reviewbot Windows


On Nov. 9, 2017, 3:45 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63710/
> 

Review Request 63710: Fixed flaky RescindRevocableOfferWithIncreasedRevocable test.

2017-11-09 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63710/
---

Review request for mesos and Jiang Yan Xu.


Bugs: MESOS-7519
https://issues.apache.org/jira/browse/MESOS-7519


Repository: mesos


Description
---

This is addendum to review https://reviews.apache.org/r/55893/.
The loop that merges outstanding offers can miss some because it
removes the items from the collection it iterates over.


Diffs
-

  src/tests/oversubscription_tests.cpp d262bbe06787f70427f4f7820e64891c7d1b5552 


Diff: https://reviews.apache.org/r/63710/diff/1/


Testing
---

`GLOG_v=2 GTEST_FILTER="*RescindRevocableOfferWithIncreasedRevocable*" 
./bin/mesos-tests.sh --verbose --gtest_repeat=1000 --gtest_break_on_failure` on 
Mac OS 10.11.6
does not fail with the patch while consistently fails without.


Thanks,

Alexander Rukletsov