Re: Review Request 63737: Handled the resource conversion for new operations in master.

2017-11-13 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63737/#review190860
---


Ship it!




Ship It!

- Jan Schlicht


On Nov. 10, 2017, 6:55 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63737/
> ---
> 
> (Updated Nov. 10, 2017, 6:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a terminal status update for an offer operaiton is received, we
> need to apply the conversion for the offer operation to the master's
> view about the total resources of the corresponding agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 49dbaa979d692061a7b479b1db4511e8357b8baf 
> 
> 
> Diff: https://reviews.apache.org/r/63737/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 63737: Handled the resource conversion for new operations in master.

2017-11-10 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63737/#review190753
---



FAIL: Failed to apply the dependent review: 59988.

Failed command: `python.exe .\support\apply-reviews.py -n -r 59988`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63737

Relevant logs:

- 
[apply-review-59988-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63737/logs/apply-review-59988-stdout.log):

```
error: patch failed: 3rdparty/stout/tests/protobuf_tests.proto:24
error: 3rdparty/stout/tests/protobuf_tests.proto: patch does not apply
```

- Mesos Reviewbot Windows


On Nov. 10, 2017, 5:55 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63737/
> ---
> 
> (Updated Nov. 10, 2017, 5:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When a terminal status update for an offer operaiton is received, we
> need to apply the conversion for the offer operation to the master's
> view about the total resources of the corresponding agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 49dbaa979d692061a7b479b1db4511e8357b8baf 
> 
> 
> Diff: https://reviews.apache.org/r/63737/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 63737: Handled the resource conversion for new operations in master.

2017-11-10 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63737/
---

Review request for mesos, Benjamin Bannier and Jan Schlicht.


Repository: mesos


Description
---

When a terminal status update for an offer operaiton is received, we
need to apply the conversion for the offer operation to the master's
view about the total resources of the corresponding agent.


Diffs
-

  src/master/master.cpp 49dbaa979d692061a7b479b1db4511e8357b8baf 


Diff: https://reviews.apache.org/r/63737/diff/1/


Testing
---

make check


Thanks,

Jie Yu