Re: Review Request 64056: Added a helper to extract consumed resources from offer operations.

2017-11-25 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64056/#review191854
---


Ship it!




Ship It!

- Jie Yu


On Nov. 24, 2017, 9:31 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64056/
> ---
> 
> (Updated Nov. 24, 2017, 9:31 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is based on the work done in
> https://reviews.apache.org/r/63104/.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp eff106f0a546f459030d5cf5b42e5eb8d4d9a34c 
>   src/common/protobuf_utils.cpp a5fc960b8387342eba4c66a711fedc92dd014e6f 
> 
> 
> Diff: https://reviews.apache.org/r/64056/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 64056: Added a helper to extract consumed resources from offer operations.

2017-11-24 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64056/#review191836
---


Ship it!




Ship It!

- Jan Schlicht


On Nov. 24, 2017, 10:31 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64056/
> ---
> 
> (Updated Nov. 24, 2017, 10:31 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch is based on the work done in
> https://reviews.apache.org/r/63104/.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.hpp eff106f0a546f459030d5cf5b42e5eb8d4d9a34c 
>   src/common/protobuf_utils.cpp a5fc960b8387342eba4c66a711fedc92dd014e6f 
> 
> 
> Diff: https://reviews.apache.org/r/64056/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Review Request 64056: Added a helper to extract consumed resources from offer operations.

2017-11-24 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64056/
---

Review request for mesos, Jie Yu and Jan Schlicht.


Repository: mesos


Description
---

This patch is based on the work done in
https://reviews.apache.org/r/63104/.


Diffs
-

  src/common/protobuf_utils.hpp eff106f0a546f459030d5cf5b42e5eb8d4d9a34c 
  src/common/protobuf_utils.cpp a5fc960b8387342eba4c66a711fedc92dd014e6f 


Diff: https://reviews.apache.org/r/64056/diff/1/


Testing
---

`make check`


Thanks,

Benjamin Bannier