Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-19 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/
---

(Updated Dec. 19, 2017, 6:39 p.m.)


Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-7361
https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description (updated)
---

This function always returns a ContainerClass, with `DEFAULT` being
the default value returned. Also simplifies the conditional
statements in mesos/containerizer.cpp to use the function added.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
85cb325fba2e49b78a1f381183a61f03ccd5194a 
  src/slave/containerizer/mesos/containerizer.cpp 
1a398a8ea7f3e49273459b318ae2e8a3eaae2d9c 


Diff: https://reviews.apache.org/r/64575/diff/3/


Testing
---

```
GTEST_FILTER="" nice make check -j16 V=0
```


Thanks,

Armand Grillet

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-18 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/
---

(Updated Dec. 18, 2017, 10:03 a.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Fixed issues.


Bugs: MESOS-7361
https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description
---

This function always returns a ContainerClass, `DEFAULT` being the
default value returned. Also simplifies the conditional statements
in mesos/containerizer.cpp to use the function added.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
85cb325fba2e49b78a1f381183a61f03ccd5194a 
  src/slave/containerizer/mesos/containerizer.cpp 
1a398a8ea7f3e49273459b318ae2e8a3eaae2d9c 


Diff: https://reviews.apache.org/r/64575/diff/3/

Changes: https://reviews.apache.org/r/64575/diff/2-3/


Testing
---

```
GTEST_FILTER="" nice make check -j16 V=0
```


Thanks,

Armand Grillet

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-15 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/#review193896
---




src/slave/containerizer/mesos/containerizer.hpp
Lines 358-359 (patched)


Please backtick class values.


- Alexander Rukletsov


On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64575/
> ---
> 
> (Updated Dec. 13, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7361
> https://issues.apache.org/jira/browse/MESOS-7361
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This function always returns a ContainerClass, `DEFAULT` being the
> default value returned. Also simplifies the conditional statements
> in mesos/containerizer.cpp to use the function added.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 965e183bb5c54f31d90e910edd35313ab380cea9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7ab0b07f689f872573ca458ae47cd6426ebc0365 
> 
> 
> Diff: https://reviews.apache.org/r/64575/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" nice make check -j16 V=0
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-15 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/#review193893
---


Fix it, then Ship it!





src/slave/containerizer/mesos/containerizer.hpp
Lines 360 (patched)


This is not quite true. Even if `config` is not optional anymore, 
`ContainerConfig.container_class` might not be set and default to `0`. Please 
kill this line.



src/slave/containerizer/mesos/containerizer.cpp
Lines 2877-2884 (patched)


Since this function can be used not only in the launch path where we have 
the container, you should check `config` is not `None`. How about something 
like this then?

```
return (config.isSome() && config->has_container_class())
  ? config->container_class()
  : ContainerClass::DEFAULT;
``


- Alexander Rukletsov


On Dec. 13, 2017, 7:47 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64575/
> ---
> 
> (Updated Dec. 13, 2017, 7:47 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7361
> https://issues.apache.org/jira/browse/MESOS-7361
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This function always returns a ContainerClass, `DEFAULT` being the
> default value returned. Also simplifies the conditional statements
> in mesos/containerizer.cpp to use the function added.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 965e183bb5c54f31d90e910edd35313ab380cea9 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 7ab0b07f689f872573ca458ae47cd6426ebc0365 
> 
> 
> Diff: https://reviews.apache.org/r/64575/diff/2/
> 
> 
> Testing
> ---
> 
> ```
> GTEST_FILTER="" nice make check -j16 V=0
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-13 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/
---

(Updated Dec. 13, 2017, 7:47 p.m.)


Review request for mesos and Alexander Rukletsov.


Changes
---

Added https://reviews.apache.org/r/64576/ content.


Bugs: MESOS-7361
https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description (updated)
---

This function always returns a ContainerClass, `DEFAULT` being the
default value returned. Also simplifies the conditional statements
in mesos/containerizer.cpp to use the function added.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
965e183bb5c54f31d90e910edd35313ab380cea9 
  src/slave/containerizer/mesos/containerizer.cpp 
7ab0b07f689f872573ca458ae47cd6426ebc0365 


Diff: https://reviews.apache.org/r/64575/diff/2/

Changes: https://reviews.apache.org/r/64575/diff/1-2/


Testing
---

```
GTEST_FILTER="" nice make check -j16 V=0
```


Thanks,

Armand Grillet

Re: Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-13 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/#review193688
---



FAIL: Some Mesos tests failed.

Reviews applied: `['64575']`

Failed command: `D:\DCOS\mesos\src\mesos-tests.exe --verbose`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64575

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64575/logs/mesos-tests-stdout.log):

```

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2453 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (2478 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2484 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (2508 ms total)

[--] Global test environment tear-down
[==] 829 tests from 84 test cases ran. (332969 ms total)
[  PASSED  ] 819 tests.
[  FAILED  ] 10 tests, listed below:
[  FAILED  ] OfferOperationStatusUpdateManagerTest.UpdateAndAckNonTerminalUpdate
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverCheckpointedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverEmptyFile
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RecoverTerminatedStream
[  FAILED  ] OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdate
[  FAILED  ] 
OfferOperationStatusUpdateManagerTest.IgnoreDuplicateUpdateAfterRecover
[  FAILED  ] OfferOperationStatusUpdateManagerTest.RejectDuplicateAck
[  FAILED  ] 
OfferOperationStatusUpdateManagerTest.RejectDuplicateAckAfterRecover
[  FAILED  ] 
OfferOperationStatusUpdateManagerTest.NonStrictRecoveryCorruptedFile
[  FAILED  ] SlaveTest.ResourceProviderPublishAll

10 FAILED TESTS
  YOU HAVE 201 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64575/logs/mesos-tests-stderr.log):

```
I1213 15:42:28.782146  8152 master.cpp:10158] Updating the state of task 
c7a854f3-dc5a-47ca-91a9-532414f74ab9 of framework 
76471eb5-27b9-46b6-9779-1743b5b0befc- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I1213 15:42:28.782146  1920 slave.cpp:3400] ShuttinI1213 15:42:28.084194  8012 
exec.cpp:162] Version: 1.5.0
I1213 15:42:28.109163  3996 exec.cpp:237] Executor registered on agent 
76471eb5-27b9-46b6-9779-1743b5b0befc-S0
I1213 15:42:28.112192  9452 executor.cpp:171] Received SUBSCRIBED event
I1213 15:42:28.117166  9452 executor.cpp:175] Subscribed executor on 
build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I1213 15:42:28.118190  9452 executor.cpp:171] Received LAUNCH event
I1213 15:42:28.122169  9452 executor.cpp:637] Starting task 
c7a854f3-dc5a-47ca-91a9-532414f74ab9
I1213 15:42:28.199184  9452 executor.cpp:477] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I1213 15:42:28.755149  9452 executor.cpp:650] Forked command at 7216
I1213 15:42:28.784148  1244 exec.cpp:435] Executor asked to shutdown
I1213 15:42:28.785146  9452 executor.cpp:171] Received SHUTDOWN event
I1213 15:42:28.785146  9452 executor.cpp:747] Shutting down
I1213 15:42:28.785146  9452 executor.cpp:854] Sending SIGTERM to process tree 
at pid 7g down framework 76471eb5-27b9-46b6-9779-1743b5b0befc-
I1213 15:42:28.782146  1920 slave.cpp:6114] Shutting down executor 
'c7a854f3-dc5a-47ca-91a9-532414f74ab9' of framework 
76471eb5-27b9-46b6-9779-1743b5b0befc- at executor(1)@10.3.1.11:50016
I1213 15:42:28.783145  1920 slave.cpp:909] Agent terminating
W1213 15:42:28.783145  1920 slave.cpp:3396] Ignoring shutdown framework 
76471eb5-27b9-46b6-9779-1743b5b0befc- because it is terminating
I1213 15:42:28.784148  8152 master.cpp:10264] Removing task 
c7a854f3-dc5a-47ca-91a9-532414f74ab9 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 76471eb5-27b9-46b6-9779-1743b5b0befc- on 
agent 76471eb5-27b9-46b6-9779-1743b5b0befc-S0 at slave(326)@10.3.1.11:49995 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1213 15:42:28.787144  6528 containerizer.cpp:2337] Destroying container 
593e260c-dd0c-4205-8a1d-d679d7a33b9a in RUNNING state
I1213 15:42:28.787144  6528 containerizer.cpp:2949] Transitioning the state of 
container 593e260c-dd0c-4205-8a1d-d679d7a33b9a from RUNNING to DESTROYING
I1213 15:42:28.787144  8152 master.cpp:1305] Agent 
76471eb5-27b9-46b6-9779-1743b5b0befc-S0 at slave(326)@10.3.1.11:49995 
(build-srv-03.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1213 15:42:28.787144  6616 hierarchical.cpp:344] Removed framework

Review Request 64575: Added containerClass() to MesosContainerizerProcess::Container.

2017-12-13 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64575/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-7361
https://issues.apache.org/jira/browse/MESOS-7361


Repository: mesos


Description
---

This function always returns a ContainerClass,
`DEFAULT` being the default value returned.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
965e183bb5c54f31d90e910edd35313ab380cea9 
  src/slave/containerizer/mesos/containerizer.cpp 
7ab0b07f689f872573ca458ae47cd6426ebc0365 


Diff: https://reviews.apache.org/r/64575/diff/1/


Testing
---

```
GTEST_FILTER="" nice make check -j16 V=0
```


Thanks,

Armand Grillet