Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`.

2017-12-27 Thread Michael Park 


> On Dec. 19, 2017, 6:13 p.m., Benjamin Mahler wrote:
> > The "upgrade" vs "normalize" inconsistency seems a little odd?

I'll follow up with a patch to change "normalize" to "upgrade".
Seems more fitting with the presence of "downgrade".


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
---


On Dec. 19, 2017, 4:51 p.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64738/
> ---
> 
> (Updated Dec. 19, 2017, 4:51 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4 
> 
> 
> Diff: https://reviews.apache.org/r/64738/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`.

2017-12-19 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/#review194205
---


Ship it!




The "upgrade" vs "normalize" inconsistency seems a little odd?

- Benjamin Mahler


On Dec. 20, 2017, 12:51 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64738/
> ---
> 
> (Updated Dec. 20, 2017, 12:51 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4 
> 
> 
> Diff: https://reviews.apache.org/r/64738/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 64738: Pulled out `upgradeResources` out of `validateAndNormalizeResources`.

2017-12-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64738/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/common/resources_utils.cpp 1676b72a9ad15bf8b131698a0600a1b0937c00b4 


Diff: https://reviews.apache.org/r/64738/diff/1/


Testing
---


Thanks,

Michael Park