Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

2017-12-20 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64761/
---

(Updated Dec. 20, 2017, 6:39 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7099
https://issues.apache.org/jira/browse/MESOS-7099


Repository: mesos


Description
---

This paves the way for improved quota headroom enforcement
for the quota role allocation stage.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.cpp 
1c767f7f778819dcfa6eff51765163aec1b70a2d 


Diff: https://reviews.apache.org/r/64761/diff/2/

Changes: https://reviews.apache.org/r/64761/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu



Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

2017-12-20 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64761/#review194294
---



FAIL: Failed to apply the dependent review: 64003.

Failed command: `python.exe .\support\apply-reviews.py -n -r 64003`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64761

Relevant logs:

- 
[apply-review-64003-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/64761/logs/apply-review-64003-stderr.log):

```
Traceback (most recent call last):
  File ".\support\apply-reviews.py", line 434, in 
main()
  File ".\support\apply-reviews.py", line 429, in main
reviewboard(options)
  File ".\support\apply-reviews.py", line 419, in reviewboard
apply_review(options)
  File ".\support\apply-reviews.py", line 160, in apply_review
commit_patch(options)
  File ".\support\apply-reviews.py", line 271, in commit_patch
message.write(data['message'])
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position 
112: ordinal not in range(128)
```

- Mesos Reviewbot Windows


On Dec. 21, 2017, 9:11 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64761/
> ---
> 
> (Updated Dec. 21, 2017, 9:11 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7099
> https://issues.apache.org/jira/browse/MESOS-7099
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This paves the way for improved quota headroom enforcement
> for the quota role allocation stage.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1c767f7f778819dcfa6eff51765163aec1b70a2d 
> 
> 
> Diff: https://reviews.apache.org/r/64761/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Re: Review Request 64761: Moved the quota headroom tracking before quota allocation.

2017-12-20 Thread Benjamin Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64761/#review194292
---


Fix it, then Ship it!




Looks good, modulo stripping the resources when decrementing the required & 
available headroom.


src/master/allocator/mesos/hierarchical.cpp
Lines 1955-1956 (patched)


Should these be stripped?


- Benjamin Mahler


On Dec. 21, 2017, 1:11 a.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64761/
> ---
> 
> (Updated Dec. 21, 2017, 1:11 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7099
> https://issues.apache.org/jira/browse/MESOS-7099
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This paves the way for improved quota headroom enforcement
> for the quota role allocation stage.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 1c767f7f778819dcfa6eff51765163aec1b70a2d 
> 
> 
> Diff: https://reviews.apache.org/r/64761/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>



Review Request 64761: Moved the quota headroom tracking before quota allocation.

2017-12-20 Thread Meng Zhu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64761/
---

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7099
https://issues.apache.org/jira/browse/MESOS-7099


Repository: mesos


Description
---

This paves the way for improved quota headroom enforcement
for the quota role allocation stage.


Diffs
-

  src/master/allocator/mesos/hierarchical.cpp 
1c767f7f778819dcfa6eff51765163aec1b70a2d 


Diff: https://reviews.apache.org/r/64761/diff/1/


Testing
---

make check


Thanks,

Meng Zhu