Re: Review Request 65126: Added a resource provider test case.

2018-01-17 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195581
---



PASS: Mesos patch 65126 was successfully built and tested.

Reviews applied: `['65125', '65126']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65126

- Mesos Reviewbot Windows


On Jan. 17, 2018, 1:05 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 17, 2018, 1:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/3/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-17 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/
---

(Updated Jan. 17, 2018, 2:05 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues.


Bugs: MESOS-8445
https://issues.apache.org/jira/browse/MESOS-8445


Repository: mesos


Description
---

Added a resource provider test case.


Diffs (updated)
-

  src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 


Diff: https://reviews.apache.org/r/65126/diff/3/

Changes: https://reviews.apache.org/r/65126/diff/2-3/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65126: Added a resource provider test case.

2018-01-17 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195549
---




src/tests/master_tests.cpp
Lines 8666 (patched)


This variable does not seem too useful.


- Benjamin Bannier


On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 16, 2018, 12:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-17 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195548
---


Fix it, then Ship it!





src/tests/master_tests.cpp
Lines 8641 (patched)


Remove one line.



src/tests/master_tests.cpp
Lines 8694 (patched)


We need to assert here.



src/tests/master_tests.cpp
Lines 8731 (patched)


`ASSERT_FALSE`


- Benjamin Bannier


On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 16, 2018, 12:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-16 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195446
---



PASS: Mesos patch 65126 was successfully built and tested.

Reviews applied: `['65125', '65126']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65126

- Mesos Reviewbot Windows


On Jan. 16, 2018, 11:04 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 16, 2018, 11:04 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-16 Thread Jan Schlicht 


> On Jan. 15, 2018, 10:57 a.m., Benjamin Bannier wrote:
> > src/tests/resource_provider_manager_tests.cpp
> > Lines 1345 (patched)
> > 
> >
> > This does look more like an agent integration test to me; maybe move it 
> > to `slave_tests.cpp` instead?

It's both, master and agent integration tests, though the focus is on the 
master. Moved it to `master_test.cpp` and renamed it to make clear that it's 
about `UpdateSlaveMessage`.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195412
---


On Jan. 16, 2018, 12:04 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 16, 2018, 12:04 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-16 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/
---

(Updated Jan. 16, 2018, 12:04 p.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Addressed issues and moved test case to `master_test.cpp`.


Bugs: MESOS-8445
https://issues.apache.org/jira/browse/MESOS-8445


Repository: mesos


Description
---

Added a resource provider test case.


Diffs (updated)
-

  src/tests/master_tests.cpp 0edf22431aad85945aeb808a05f11e0bd832bccf 


Diff: https://reviews.apache.org/r/65126/diff/2/

Changes: https://reviews.apache.org/r/65126/diff/1-2/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 65126: Added a resource provider test case.

2018-01-15 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195412
---




src/tests/resource_provider_manager_tests.cpp
Lines 1345 (patched)


This does look more like an agent integration test to me; maybe move it to 
`slave_tests.cpp` instead?



src/tests/resource_provider_manager_tests.cpp
Lines 1440-1443 (patched)


Even though it works I think having the setup expecations for side-effects 
before triggering it.

Let's move these two above the `send` just above.



src/tests/resource_provider_manager_tests.cpp
Lines 1448 (patched)


We need to make a hard assert that `offers` is not empty.



src/tests/resource_provider_manager_tests.cpp
Lines 1453-1454 (patched)


Since these are the core pieces we test here, we use expectations instead 
of assertions here.


- Benjamin Bannier


On Jan. 12, 2018, 3:16 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 12, 2018, 3:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8445
> https://issues.apache.org/jira/browse/MESOS-8445
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> d80823c47963e969113dae3623b18b7639c890fc 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195331
---



PASS: Mesos patch 65126 was successfully built and tested.

Reviews applied: `['65125', '65126']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65126

- Mesos Reviewbot Windows


On Jan. 12, 2018, 2:16 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65126/
> ---
> 
> (Updated Jan. 12, 2018, 2:16 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a resource provider test case.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> d80823c47963e969113dae3623b18b7639c890fc 
> 
> 
> Diff: https://reviews.apache.org/r/65126/diff/1/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 65126: Added a resource provider test case.

2018-01-12 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/#review195321
---



FAIL: mesos-java failed to build.

Reviews applied: `['65125', '65126']`

Failed command: `cmake.exe --build . --target mesos-java`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65126

Relevant logs:

- 
[mesos-java-build-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65126/logs/mesos-java-build-cmake-stdout.log):

```
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(2601):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3091):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3426):
 warning C4996: 'strerror': This function or variable may be unsafe. Consider 
using strerror_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3500):
 warning C4996: 'inet_ntoa': Use inet_ntop() or InetNtop() instead or define 
_WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3501):
 warning C4996: 'sprintf': This function or variable may be unsafe. Consider 
using sprintf_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. 
See online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479):
 warning C4101: 'addrstr': unreferenced local variable 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj]
 [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124):
 warning C4996: 'fopen': This function or variable may be unsafe. Consider 
using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See 
online help for details. 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
 warning C4267: 'initializing': conversion from 'size_t' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
  
D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] 
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]

Review Request 65126: Added a resource provider test case.

2018-01-12 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65126/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Repository: mesos


Description
---

Added a resource provider test case.


Diffs
-

  src/tests/resource_provider_manager_tests.cpp 
d80823c47963e969113dae3623b18b7639c890fc 


Diff: https://reviews.apache.org/r/65126/diff/1/


Testing
---

make check


Thanks,

Jan Schlicht