Re: Review Request 65441: Deleted deprecated Windows build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review198257 --- Bad review! Reviews applied: [] Error: No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list. - Mesos Reviewbot On Jan. 31, 2018, 6:59 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65441/ > --- > > (Updated Jan. 31, 2018, 6:59 p.m.) > > > Review request for mesos. > > > Repository: mesos > > > Description > --- > > This script has been unmaintained and is no longer used. The build > process for Windows has improved to the point that scripting it has > become unnecessary. So we delete it to avoid confusion over a likely > broken script. > > > Diffs > - > > support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e > > > Diff: https://reviews.apache.org/r/65441/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65441: Deleted deprecated Windows build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review198256 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['65441']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441 Relevant logs: - [stout-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/stout-tests-stdout.log): ``` [ RUN ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile [ OK ] RmdirTest.SYMLINK_RemoveDirectoryWithSymbolicLinkTargetFile (4 ms) [ RUN ] RmdirTest.RemoveDirectoryButPreserveRoot [ OK ] RmdirTest.RemoveDirectoryButPreserveRoot (5 ms) [--] 11 tests from RmdirTest (59 ms total) [--] 1 test from SocketTests [ RUN ] SocketTests.InitSocket [ OK ] SocketTests.InitSocket (2 ms) [--] 1 test from SocketTests (2 ms total) [--] 2 tests from StrerrorTest [ RUN ] StrerrorTest.ValidErrno [ OK ] StrerrorTest.ValidErrno (0 ms) [ RUN ] StrerrorTest.InvalidErrno [ OK ] StrerrorTest.InvalidErrno (0 ms) [--] 2 tests from StrerrorTest (1 ms total) [--] Global test environment tear-down [==] 273 tests from 46 test cases ran. (4132 ms total) [ PASSED ] 270 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] OsTest.SYMLINK_Realpath [ FAILED ] FsTest.CreateDirectoryAtMaxPath [ FAILED ] FsTest.CreateDirectoryLongerThanMaxPath 3 FAILED TESTS YOU HAVE 7 DISABLED TESTS ``` - [stout-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/stout-tests-stderr.log): ``` 'invalid.command' is not recognized as an internal or external command, operable program or batch file. Subcommand 'subcommand' is not available Usage: command [OPTIONS] Available subcommands: help subcommand2 Multiple subcommands have name 'subcommand' ``` - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (96 ms) [--] 9 tests from Endpoint/SlaveEndpointTest (917 ms total) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (37 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (71 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2281 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (2304 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (2154 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (2175 ms total) [--] Global test environment tear-down [==] 914 tests from 90 test cases ran. (412002 ms total) [ PASSED ] 913 tests. [ FAILED ] 1 test, listed below: [ FAILED ] FilesTest.DebugTest 1 FAILED TEST YOU HAVE 211 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441/logs/mesos-tests-stderr.log): ``` I0225 00:18:02.365806 1744 master.cpp:10258] Updating the state of task d07debe9-02a1-43d7-8763-04a842fe98cb of framework cf9e5aa6-58cc-4234-9d5e-0806158f4477- (latest state: TASK_KILLED, status I0225 00:18:01.730516 2764 exec.cpp:162] Version: 1.6.0 I0225 00:18:01.752516 3652 exec.cpp:236] Executor registered on agent cf9e5aa6-58cc-4234-9d5e-0806158f4477-S0 I0225 00:18:01.756512 5872 executor.cpp:174] Received SUBSCRIBED event I0225 00:18:01.761513 5872 executor.cpp:178] Subscribed executor on build-srv-04.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net I0225 00:18:01.761513 5872 executor.cpp:174] Received LAUNCH event I0225 00:18:01.765516 5872 executor.cpp:646] Starting task d07debe9-02a1-43d7-8763-04a842fe98cb I0225 00:18:01.838516 5872 executor.cpp:481] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0225 00:18:02.339804 5872 executor.cpp:659] Forked command at 9816 I0225 00:18:02.367802 8096 exec.cpp:445] Executor asked to shutdown I0225 00:18:02.367802 5872 executor.cpp:174] Received SHUTDOWN event I0225 00:18:02.367802 5872 executor.cpp:756] Shutting down I0225 00:18:02.367802 5872 executor.cpp:866] Sending SIGTERM to process tree at pid 9update state:
Re: Review Request 65441: Deleted deprecated Windows build script.
> On Jan. 31, 2018, 12:23 p.m., Mesos Reviewbot Windows wrote: > > PASS: Mesos patch 65441 was successfully built and tested. > > > > Reviews applied: `['65441']` > > > > All the build artifacts available at: > > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441 That confirms the review bot doesn't use `verify-reviews.py`. - Andrew --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review196587 --- On Jan. 31, 2018, 10:59 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65441/ > --- > > (Updated Jan. 31, 2018, 10:59 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This script has been unmaintained and is no longer used. The build > process for Windows has improved to the point that scripting it has > become unnecessary. So we delete it to avoid confusion over a likely > broken script. > > > Diffs > - > > support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e > > > Diff: https://reviews.apache.org/r/65441/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65441: Deleted deprecated Windows build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review196587 --- PASS: Mesos patch 65441 was successfully built and tested. Reviews applied: `['65441']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65441 - Mesos Reviewbot Windows On Jan. 31, 2018, 6:59 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65441/ > --- > > (Updated Jan. 31, 2018, 6:59 p.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This script has been unmaintained and is no longer used. The build > process for Windows has improved to the point that scripting it has > become unnecessary. So we delete it to avoid confusion over a likely > broken script. > > > Diffs > - > > support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e > > > Diff: https://reviews.apache.org/r/65441/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 65441: Deleted deprecated Windows build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/#review196578 --- Before we commit this, we need to look at these two references: ``` support/verify-reviews.py 178:command = "support\windows-build.bat" support/jenkins/windows-buildbot.bat 38:"support/windows-build.bat" ``` - Andrew Schwartzmeyer On Jan. 31, 2018, 10:59 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65441/ > --- > > (Updated Jan. 31, 2018, 10:59 a.m.) > > > Review request for mesos and Joseph Wu. > > > Repository: mesos > > > Description > --- > > This script has been unmaintained and is no longer used. The build > process for Windows has improved to the point that scripting it has > become unnecessary. So we delete it to avoid confusion over a likely > broken script. > > > Diffs > - > > support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e > > > Diff: https://reviews.apache.org/r/65441/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 65441: Deleted deprecated Windows build script.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65441/ --- Review request for mesos and Joseph Wu. Repository: mesos Description --- This script has been unmaintained and is no longer used. The build process for Windows has improved to the point that scripting it has become unnecessary. So we delete it to avoid confusion over a likely broken script. Diffs - support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e Diff: https://reviews.apache.org/r/65441/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
