Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-27 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

(Updated Feb. 27, 2018, 7:04 p.m.)


Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description (updated)
---

Added an overloaded version of `os::realpath` to stout for evaluating real path 
within a scoped root directory.


Diffs (updated)
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/2/

Changes: https://reviews.apache.org/r/65812/diff/1-2/


Testing
---


Thanks,

Jason Lai

Re: Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/#review198317
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['65811', '65812']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65812/logs/stout-tests-cmake-stdout.log):

```
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\zlib-1.2.8.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj" (default target) (6) ->
 CUSTOMBUILD : CMake warning :  
[D:\DCOS\mesos\3rdparty\curl-7.57.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   (Link target) -> 
 ip_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 mac_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 main.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 os_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 path_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 subcommand_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 copyfile_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 env_tests.obj : error LNK2005: "class std::basic_string __cdecl path::clean(class 
std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 filesystem_tests.obj : error LNK2005: "class 
std::basic_string __cdecl path::clean(class std::basic_string const &,char)" 
(?clean@path@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AEBV23@D@Z)
 already defined in flags_tests.obj 
[D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj]
 process_tests.obj : error LNK2005: "class 
std::basic_string

Review Request 65812: Added an overloaded version of `os::realpath` to stout for evaluating real path within a scoped root directory

2018-02-26 Thread Jason Lai 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65812/
---

Review request for mesos, Anish Gupta, Eric Chung, Gilbert Song, Jie Yu, James 
Peach, and Zhitao Li.


Bugs: MESOS-8257
https://issues.apache.org/jira/browse/MESOS-8257


Repository: mesos


Description
---

Added an overloaded version of `os::realpath` to stout for evaluating real path 
within a scoped root directory


Diffs
-

  3rdparty/stout/include/stout/os/posix/realpath.hpp 
31352cefc5b8d0ccd9af8f6dabdec4a959fded32 


Diff: https://reviews.apache.org/r/65812/diff/1/


Testing
---


Thanks,

Jason Lai