Re: Review Request 65842: Stout: Changed `os::spawn` to return `Option` instead of `int`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/#review198734 --- Ship it! Ship It! - Andrew Schwartzmeyer On March 1, 2018, 1:50 a.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65842/ > --- > > (Updated March 1, 2018, 1:50 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park. > > > Bugs: MESOS-4549 > https://issues.apache.org/jira/browse/MESOS-4549 > > > Repository: mesos > > > Description > --- > > Similar to `os::system`, `os::spawn` returned -1 on error, which is a > valid exit code on Windows. Using the same solution for `os::system`, > now when `os::spawn` fails, `None` will be returned. Otherwise, the > process exit code will be returned. > > > Diffs > - > > 3rdparty/stout/include/stout/os/posix/copyfile.hpp > 0d9ed5babbff05a84740df3dbe1594f0e3012360 > 3rdparty/stout/include/stout/os/posix/shell.hpp > b878718e137e4c8b599e0f4dac67672d8df27f7d > 3rdparty/stout/include/stout/os/windows/shell.hpp > 1696d084c8453fa0eb9ef41e0a4128e547f7f53c > > > Diff: https://reviews.apache.org/r/65842/diff/2/ > > > Testing > --- > > make check > > > Thanks, > > Akash Gupta > >
Re: Review Request 65842: Stout: Changed `os::spawn` to return `Option` instead of `int`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65842/ --- (Updated March 1, 2018, 9:50 a.m.) Review request for mesos, Andrew Schwartzmeyer, Joseph Wu, and Michael Park. Changes --- split commit into 2. Summary (updated) - Stout: Changed `os::spawn` to return `Option` instead of `int`. Bugs: MESOS-4549 https://issues.apache.org/jira/browse/MESOS-4549 Repository: mesos Description --- Similar to `os::system`, `os::spawn` returned -1 on error, which is a valid exit code on Windows. Using the same solution for `os::system`, now when `os::spawn` fails, `None` will be returned. Otherwise, the process exit code will be returned. Diffs (updated) - 3rdparty/stout/include/stout/os/posix/copyfile.hpp 0d9ed5babbff05a84740df3dbe1594f0e3012360 3rdparty/stout/include/stout/os/posix/shell.hpp b878718e137e4c8b599e0f4dac67672d8df27f7d 3rdparty/stout/include/stout/os/windows/shell.hpp 1696d084c8453fa0eb9ef41e0a4128e547f7f53c Diff: https://reviews.apache.org/r/65842/diff/2/ Changes: https://reviews.apache.org/r/65842/diff/1-2/ Testing --- make check Thanks, Akash Gupta
