Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-23 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/
---

(Updated April 24, 2018, 1:04 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Fixed the type pointed out by Benjamin.


Bugs: MESOS-8492
https://issues.apache.org/jira/browse/MESOS-8492


Repository: mesos


Description
---

Added comments and made some renaming in SLRP.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
8ca2d3a98858940e6e027becefb53c2f00b4ae43 


Diff: https://reviews.apache.org/r/65974/diff/4/

Changes: https://reviews.apache.org/r/65974/diff/3-4/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-20 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/#review201625
---


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 352 (patched)


`s/reconfile/reconcile/`?


- Benjamin Bannier


On April 12, 2018, 5:33 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65974/
> ---
> 
> (Updated April 12, 2018, 5:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8492
> https://issues.apache.org/jira/browse/MESOS-8492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added comments and made some renaming in SLRP.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/65974/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-12 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/#review201063
---


Ship it!




Ship It!

- Jie Yu


On April 12, 2018, 3:33 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65974/
> ---
> 
> (Updated April 12, 2018, 3:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8492
> https://issues.apache.org/jira/browse/MESOS-8492
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added comments and made some renaming in SLRP.
> 
> 
> Diffs
> -
> 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/65974/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-04-11 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/
---

(Updated April 12, 2018, 3:33 a.m.)


Review request for mesos, Benjamin Bannier and Jie Yu.


Changes
---

Rebased.


Repository: mesos


Description
---

Added comments and made some renaming in SLRP.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/65974/diff/3/

Changes: https://reviews.apache.org/r/65974/diff/2-3/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Re: Review Request 65974: Added comments and made some renaming in SLRP.

2018-03-19 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/
---

(Updated March 20, 2018, 2:05 a.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebased.


Repository: mesos


Description
---

Added comments and made some renaming in SLRP.


Diffs (updated)
-

  src/resource_provider/storage/provider.cpp 
bb19ed4b6b1b8f5f6b327461a737517497c8c38e 


Diff: https://reviews.apache.org/r/65974/diff/2/

Changes: https://reviews.apache.org/r/65974/diff/1-2/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao

Review Request 65974: Added comments and made some renaming in SLRP.

2018-03-07 Thread Chun-Hung Hsiao 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65974/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Added comments and made some renaming in SLRP.


Diffs
-

  src/resource_provider/storage/provider.cpp 
63dde512fd8cc9f68f5f48a96869eb09b23b6f4a 


Diff: https://reviews.apache.org/r/65974/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao