Re: Review Request 66114: Added supporting scripts for Mesos LLVM Tools.

[Benno Evers]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66114/#review208131
---




support/llvm/install.sh
Lines 24 (patched)


This needs to be

```
LLVM_DIR="$(git rev-parse --git-common-dir)/llvm"
```

to account for repositories where the `.git` directory is not inside the 
top-level directory. (in particular, when using several worktrees with `git 
worktree`)


- Benno Evers


On March 16, 2018, 10:58 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66114/
> ---
> 
> (Updated March 16, 2018, 10:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added supporting scripts for Mesos LLVM Tools.
> 
> 
> Diffs
> -
> 
>   support/llvm/README.md PRE-CREATION 
>   support/llvm/install.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66114/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Re: Review Request 66114: Added supporting scripts for Mesos LLVM Tools.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66114/#review199408
---


Ship it!




We might want to merge this patch with https://reviews.apache.org/r/66115/ 
which we already directly reference here.


support/llvm/install.sh
Lines 54-60 (patched)


Any reason we are not using a trailing dot here, e.g., `10.11.*` instead of 
`10.11*`?


- Benjamin Bannier


On March 16, 2018, 11:58 a.m., Michael Park wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66114/
> ---
> 
> (Updated March 16, 2018, 11:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added supporting scripts for Mesos LLVM Tools.
> 
> 
> Diffs
> -
> 
>   support/llvm/README.md PRE-CREATION 
>   support/llvm/install.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/66114/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Review Request 66114: Added supporting scripts for Mesos LLVM Tools.

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66114/
---

Review request for mesos, Benjamin Bannier and Benjamin Mahler.


Repository: mesos


Description
---

See summary.


Diffs
-

  support/llvm/README.md PRE-CREATION 
  support/llvm/install.sh PRE-CREATION 


Diff: https://reviews.apache.org/r/66114/diff/1/


Testing
---


Thanks,

Michael Park