Re: Review Request 66228: Added Call for updating framework info.

2018-05-09 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
---

(Updated May 9, 2018, 9:14 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Added Call for updating framework info.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
fcfec5e417463103e98dd6917722b4fde41cac7c 


Diff: https://reviews.apache.org/r/66228/diff/9/

Changes: https://reviews.apache.org/r/66228/diff/8-9/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202532
---




include/mesos/scheduler/scheduler.proto
Lines 479 (patched)


Should we document the 200 OK response somewhere?


- Benjamin Mahler


On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> ---
> 
> (Updated April 20, 2018, 8:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Call for updating framework info.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> f6a780a7b75878b9e74402a28a25bb868f7ac36f 
>   include/mesos/v1/scheduler/scheduler.proto 
> fcfec5e417463103e98dd6917722b4fde41cac7c 
> 
> 
> Diff: https://reviews.apache.org/r/66228/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler 


> On May 7, 2018, 2:41 a.m., Benjamin Mahler wrote:
> >

Can you add some description to this change?


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202528
---


On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> ---
> 
> (Updated April 20, 2018, 8:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Call for updating framework info.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> f6a780a7b75878b9e74402a28a25bb868f7ac36f 
>   include/mesos/v1/scheduler/scheduler.proto 
> fcfec5e417463103e98dd6917722b4fde41cac7c 
> 
> 
> Diff: https://reviews.apache.org/r/66228/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 66228: Added Call for updating framework info.

2018-05-06 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/#review202528
---




include/mesos/scheduler/scheduler.proto
Lines 477-478 (patched)


Per discussion, can you document that this is inconsistent with the 
re-registration allowed updates and add a TODO indicating that we'll make it 
consistent in a follow up patch and allow the same changes in both approaches?

Alternatively, this chain could be updated to make the two paths consistent.


- Benjamin Mahler


On April 20, 2018, 8:19 p.m., Kapil Arya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66228/
> ---
> 
> (Updated April 20, 2018, 8:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Till Toenshoff.
> 
> 
> Bugs: MESOS-7258
> https://issues.apache.org/jira/browse/MESOS-7258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Call for updating framework info.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler/scheduler.proto 
> f6a780a7b75878b9e74402a28a25bb868f7ac36f 
>   include/mesos/v1/scheduler/scheduler.proto 
> fcfec5e417463103e98dd6917722b4fde41cac7c 
> 
> 
> Diff: https://reviews.apache.org/r/66228/diff/8/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 66228: Added Call for updating framework info.

2018-04-20 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
---

(Updated April 20, 2018, 4:19 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Added Call for updating framework info.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
25ebcfcb07cb4fb928dcfdc242bb6509c9080491 


Diff: https://reviews.apache.org/r/66228/diff/5/

Changes: https://reviews.apache.org/r/66228/diff/4-5/


Testing
---


Thanks,

Kapil Arya

Re: Review Request 66228: Added Call for updating framework info.

2018-04-11 Thread Kapil Arya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66228/
---

(Updated April 11, 2018, 1:28 p.m.)


Review request for mesos, Benjamin Mahler and Till Toenshoff.


Bugs: MESOS-7258
https://issues.apache.org/jira/browse/MESOS-7258


Repository: mesos


Description
---

Added Call for updating framework info.


Diffs (updated)
-

  include/mesos/scheduler/scheduler.proto 
f6a780a7b75878b9e74402a28a25bb868f7ac36f 
  include/mesos/v1/scheduler/scheduler.proto 
25ebcfcb07cb4fb928dcfdc242bb6509c9080491 


Diff: https://reviews.apache.org/r/66228/diff/4/

Changes: https://reviews.apache.org/r/66228/diff/3-4/


Testing
---


Thanks,

Kapil Arya