Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/ --- (Updated May 1, 2018, 2:32 p.m.) Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Changes --- Pass the `Option` by const ref. Bugs: MESOS-8682 https://issues.apache.org/jira/browse/MESOS-8682 Repository: mesos Description --- The latter should be used everywhere but in the implementation for consistency with the POSIX side of the code. Also meant fixing the included header (and spacing). Diffs (updated) - 3rdparty/stout/include/stout/internal/windows/inherit.hpp 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 3rdparty/stout/include/stout/os/windows/close.hpp ff635e44235d63888a210cd68d49f6678a851e31 3rdparty/stout/include/stout/os/windows/dup.hpp 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 3rdparty/stout/include/stout/os/windows/fcntl.hpp bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 3rdparty/stout/include/stout/os/windows/fsync.hpp 8405247280b51e74a172317816096ca77fdfd1e7 3rdparty/stout/include/stout/os/windows/ftruncate.hpp fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 3rdparty/stout/include/stout/os/windows/pipe.hpp 365db9480f6258a03ef2e760a19abef8ab177e58 3rdparty/stout/include/stout/os/windows/read.hpp 8047ad590fcc46d3ec46b551472d8c518ae49cc1 3rdparty/stout/include/stout/os/windows/sendfile.hpp fff5872db6b3f69464e41e6d108a107e4eeabd12 3rdparty/stout/include/stout/os/windows/shell.hpp aacd746922495f994891aa85d3e4fa95e2bd1c44 3rdparty/stout/include/stout/os/windows/socket.hpp 259b05b8c85e399feaccec698d58b7d540cad368 3rdparty/stout/include/stout/os/windows/write.hpp 71006489918d9495d37d2fdfdca08b40b419481a 3rdparty/stout/include/stout/windows/os.hpp 900baf9be4e3089cb43e444b14b155a80bcd1591 Diff: https://reviews.apache.org/r/66425/diff/2/ Changes: https://reviews.apache.org/r/66425/diff/1-2/ Testing --- Thanks, Andrew Schwartzmeyer
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review201023 --- Ship it! - Joseph Wu On April 3, 2018, 10:47 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66425/ > --- > > (Updated April 3, 2018, 10:47 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The latter should be used everywhere but in the implementation for > consistency with the POSIX side of the code. > > Also meant fixing the included header (and spacing). > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 > 3rdparty/stout/include/stout/os/windows/close.hpp > ff635e44235d63888a210cd68d49f6678a851e31 > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa > 3rdparty/stout/include/stout/os/windows/fsync.hpp > 8405247280b51e74a172317816096ca77fdfd1e7 > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 > 3rdparty/stout/include/stout/os/windows/pipe.hpp > 365db9480f6258a03ef2e760a19abef8ab177e58 > 3rdparty/stout/include/stout/os/windows/read.hpp > 8047ad590fcc46d3ec46b551472d8c518ae49cc1 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > fff5872db6b3f69464e41e6d108a107e4eeabd12 > 3rdparty/stout/include/stout/os/windows/shell.hpp > aacd746922495f994891aa85d3e4fa95e2bd1c44 > 3rdparty/stout/include/stout/os/windows/socket.hpp > 259b05b8c85e399feaccec698d58b7d540cad368 > 3rdparty/stout/include/stout/os/windows/write.hpp > 71006489918d9495d37d2fdfdca08b40b419481a > 3rdparty/stout/include/stout/windows/os.hpp > 739ee4da3f09d2a9597d4451e755e77903e9287d > > > Diff: https://reviews.apache.org/r/66425/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review200588 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66425/ > --- > > (Updated April 4, 2018, 5:47 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The latter should be used everywhere but in the implementation for > consistency with the POSIX side of the code. > > Also meant fixing the included header (and spacing). > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 > 3rdparty/stout/include/stout/os/windows/close.hpp > ff635e44235d63888a210cd68d49f6678a851e31 > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa > 3rdparty/stout/include/stout/os/windows/fsync.hpp > 8405247280b51e74a172317816096ca77fdfd1e7 > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 > 3rdparty/stout/include/stout/os/windows/pipe.hpp > 365db9480f6258a03ef2e760a19abef8ab177e58 > 3rdparty/stout/include/stout/os/windows/read.hpp > 8047ad590fcc46d3ec46b551472d8c518ae49cc1 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > fff5872db6b3f69464e41e6d108a107e4eeabd12 > 3rdparty/stout/include/stout/os/windows/shell.hpp > aacd746922495f994891aa85d3e4fa95e2bd1c44 > 3rdparty/stout/include/stout/os/windows/socket.hpp > 259b05b8c85e399feaccec698d58b7d540cad368 > 3rdparty/stout/include/stout/os/windows/write.hpp > 71006489918d9495d37d2fdfdca08b40b419481a > 3rdparty/stout/include/stout/windows/os.hpp > 739ee4da3f09d2a9597d4451e755e77903e9287d > > > Diff: https://reviews.apache.org/r/66425/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/#review200506 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66425/ > --- > > (Updated April 4, 2018, 5:47 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The latter should be used everywhere but in the implementation for > consistency with the POSIX side of the code. > > Also meant fixing the included header (and spacing). > > > Diffs > - > > 3rdparty/stout/include/stout/internal/windows/inherit.hpp > 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 > 3rdparty/stout/include/stout/os/windows/close.hpp > ff635e44235d63888a210cd68d49f6678a851e31 > 3rdparty/stout/include/stout/os/windows/dup.hpp > 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 > 3rdparty/stout/include/stout/os/windows/fcntl.hpp > bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa > 3rdparty/stout/include/stout/os/windows/fsync.hpp > 8405247280b51e74a172317816096ca77fdfd1e7 > 3rdparty/stout/include/stout/os/windows/ftruncate.hpp > fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 > 3rdparty/stout/include/stout/os/windows/pipe.hpp > 365db9480f6258a03ef2e760a19abef8ab177e58 > 3rdparty/stout/include/stout/os/windows/read.hpp > 8047ad590fcc46d3ec46b551472d8c518ae49cc1 > 3rdparty/stout/include/stout/os/windows/sendfile.hpp > fff5872db6b3f69464e41e6d108a107e4eeabd12 > 3rdparty/stout/include/stout/os/windows/shell.hpp > aacd746922495f994891aa85d3e4fa95e2bd1c44 > 3rdparty/stout/include/stout/os/windows/socket.hpp > 259b05b8c85e399feaccec698d58b7d540cad368 > 3rdparty/stout/include/stout/os/windows/write.hpp > 71006489918d9495d37d2fdfdca08b40b419481a > 3rdparty/stout/include/stout/windows/os.hpp > 739ee4da3f09d2a9597d4451e755e77903e9287d > > > Diff: https://reviews.apache.org/r/66425/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 66425: Windows: Replaced `WindowsFD` with `int_fd` typedef.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66425/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Repository: mesos Description --- The latter should be used everywhere but in the implementation for consistency with the POSIX side of the code. Also meant fixing the included header (and spacing). Diffs - 3rdparty/stout/include/stout/internal/windows/inherit.hpp 6da6f8eb1382d226c8b16a8e4cbb454205ef4045 3rdparty/stout/include/stout/os/windows/close.hpp ff635e44235d63888a210cd68d49f6678a851e31 3rdparty/stout/include/stout/os/windows/dup.hpp 265046cf7ffc14f7326711d295aa7dd4f0a8a1e3 3rdparty/stout/include/stout/os/windows/fcntl.hpp bf8c38acad60f9b0eb752053dcd53a9fda7b8bfa 3rdparty/stout/include/stout/os/windows/fsync.hpp 8405247280b51e74a172317816096ca77fdfd1e7 3rdparty/stout/include/stout/os/windows/ftruncate.hpp fc4a8b5040d56fa9766687e44ce17fbe47d9e8f0 3rdparty/stout/include/stout/os/windows/pipe.hpp 365db9480f6258a03ef2e760a19abef8ab177e58 3rdparty/stout/include/stout/os/windows/read.hpp 8047ad590fcc46d3ec46b551472d8c518ae49cc1 3rdparty/stout/include/stout/os/windows/sendfile.hpp fff5872db6b3f69464e41e6d108a107e4eeabd12 3rdparty/stout/include/stout/os/windows/shell.hpp aacd746922495f994891aa85d3e4fa95e2bd1c44 3rdparty/stout/include/stout/os/windows/socket.hpp 259b05b8c85e399feaccec698d58b7d540cad368 3rdparty/stout/include/stout/os/windows/write.hpp 71006489918d9495d37d2fdfdca08b40b419481a 3rdparty/stout/include/stout/windows/os.hpp 739ee4da3f09d2a9597d4451e755e77903e9287d Diff: https://reviews.apache.org/r/66425/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
