Re: Review Request 66426: Windows: More constness in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review201028 --- Ship it! - Joseph Wu On April 3, 2018, 10:48 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66426/ > --- > > (Updated April 3, 2018, 10:48 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > Also small fixes such as `reserve` over an allocation, and a bad name > `si` instead of `info`. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/getcwd.hpp > f316d618226872b57d950b468352176a7a0cb45a > 3rdparty/stout/include/stout/os/windows/getenv.hpp > 58012e03aca5dfa2f65fc183b21533dd0ed91d8d > 3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/killtree.hpp > ce8bdcd18305ffb758f22a6c2bbc7393675aebdf > 3rdparty/stout/include/stout/os/windows/mkdir.hpp > 8d8d80bee77253086939c28333b0413bd8b8b8b6 > 3rdparty/stout/include/stout/os/windows/pagesize.hpp > ddf23c1c5d15c1dd7de37e98673b70836a0e2c5c > 3rdparty/stout/include/stout/os/windows/realpath.hpp > c6bad5063c8d8255b29a3a6cb9ea51e13c42275c > 3rdparty/stout/include/stout/os/windows/su.hpp > 1bfbb261edbd25b4552742fc0597e331012cad98 > 3rdparty/stout/include/stout/os/windows/temp.hpp > 9cf467fd9358cc4de702e0501263abcd28a0fa8c > > > Diff: https://reviews.apache.org/r/66426/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66426: Windows: More constness in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review200589 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 5:48 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66426/ > --- > > (Updated April 4, 2018, 5:48 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > Also small fixes such as `reserve` over an allocation, and a bad name > `si` instead of `info`. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/getcwd.hpp > f316d618226872b57d950b468352176a7a0cb45a > 3rdparty/stout/include/stout/os/windows/getenv.hpp > 58012e03aca5dfa2f65fc183b21533dd0ed91d8d > 3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/killtree.hpp > ce8bdcd18305ffb758f22a6c2bbc7393675aebdf > 3rdparty/stout/include/stout/os/windows/mkdir.hpp > 8d8d80bee77253086939c28333b0413bd8b8b8b6 > 3rdparty/stout/include/stout/os/windows/pagesize.hpp > ddf23c1c5d15c1dd7de37e98673b70836a0e2c5c > 3rdparty/stout/include/stout/os/windows/realpath.hpp > c6bad5063c8d8255b29a3a6cb9ea51e13c42275c > 3rdparty/stout/include/stout/os/windows/su.hpp > 1bfbb261edbd25b4552742fc0597e331012cad98 > 3rdparty/stout/include/stout/os/windows/temp.hpp > 9cf467fd9358cc4de702e0501263abcd28a0fa8c > > > Diff: https://reviews.apache.org/r/66426/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66426: Windows: More constness in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/#review200489 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:48 a.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66426/ > --- > > (Updated April 4, 2018, 5:48 a.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > Also small fixes such as `reserve` over an allocation, and a bad name > `si` instead of `info`. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/getcwd.hpp > f316d618226872b57d950b468352176a7a0cb45a > 3rdparty/stout/include/stout/os/windows/getenv.hpp > 58012e03aca5dfa2f65fc183b21533dd0ed91d8d > 3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION > 3rdparty/stout/include/stout/os/windows/killtree.hpp > ce8bdcd18305ffb758f22a6c2bbc7393675aebdf > 3rdparty/stout/include/stout/os/windows/mkdir.hpp > 8d8d80bee77253086939c28333b0413bd8b8b8b6 > 3rdparty/stout/include/stout/os/windows/pagesize.hpp > ddf23c1c5d15c1dd7de37e98673b70836a0e2c5c > 3rdparty/stout/include/stout/os/windows/realpath.hpp > c6bad5063c8d8255b29a3a6cb9ea51e13c42275c > 3rdparty/stout/include/stout/os/windows/su.hpp > 1bfbb261edbd25b4552742fc0597e331012cad98 > 3rdparty/stout/include/stout/os/windows/temp.hpp > 9cf467fd9358cc4de702e0501263abcd28a0fa8c > > > Diff: https://reviews.apache.org/r/66426/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 66426: Windows: More constness in stout.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66426/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Repository: mesos Description --- Also small fixes such as `reserve` over an allocation, and a bad name `si` instead of `info`. Diffs - 3rdparty/stout/include/stout/os/windows/getcwd.hpp f316d618226872b57d950b468352176a7a0cb45a 3rdparty/stout/include/stout/os/windows/getenv.hpp 58012e03aca5dfa2f65fc183b21533dd0ed91d8d 3rdparty/stout/include/stout/os/windows/jobobject.hpp PRE-CREATION 3rdparty/stout/include/stout/os/windows/killtree.hpp ce8bdcd18305ffb758f22a6c2bbc7393675aebdf 3rdparty/stout/include/stout/os/windows/mkdir.hpp 8d8d80bee77253086939c28333b0413bd8b8b8b6 3rdparty/stout/include/stout/os/windows/pagesize.hpp ddf23c1c5d15c1dd7de37e98673b70836a0e2c5c 3rdparty/stout/include/stout/os/windows/realpath.hpp c6bad5063c8d8255b29a3a6cb9ea51e13c42275c 3rdparty/stout/include/stout/os/windows/su.hpp 1bfbb261edbd25b4552742fc0597e331012cad98 3rdparty/stout/include/stout/os/windows/temp.hpp 9cf467fd9358cc4de702e0501263abcd28a0fa8c Diff: https://reviews.apache.org/r/66426/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
