Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review201259 --- Ship it! - Joseph Wu On April 4, 2018, 12:17 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66429/ > --- > > (Updated April 4, 2018, 12:17 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The deleted code was purely self-referential. > > > Diffs > - > > 3rdparty/libprocess/src/subprocess_windows.cpp > 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a > > > Diff: https://reviews.apache.org/r/66429/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review200597 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:17 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66429/ > --- > > (Updated April 4, 2018, 7:17 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The deleted code was purely self-referential. > > > Diffs > - > > 3rdparty/libprocess/src/subprocess_windows.cpp > 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a > > > Diff: https://reviews.apache.org/r/66429/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/#review200509 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:17 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66429/ > --- > > (Updated April 4, 2018, 7:17 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8682 > https://issues.apache.org/jira/browse/MESOS-8682 > > > Repository: mesos > > > Description > --- > > The deleted code was purely self-referential. > > > Diffs > - > > 3rdparty/libprocess/src/subprocess_windows.cpp > 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a > > > Diff: https://reviews.apache.org/r/66429/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/ --- (Updated April 4, 2018, 12:17 p.m.) Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Changes --- Changed ordering. Bugs: MESOS-8682 https://issues.apache.org/jira/browse/MESOS-8682 Repository: mesos Description --- The deleted code was purely self-referential. Diffs - 3rdparty/libprocess/src/subprocess_windows.cpp 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a Diff: https://reviews.apache.org/r/66429/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
Review Request 66429: Windows: Deleted dead code from `process::internal` namespace.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66429/ --- Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Repository: mesos Description --- The deleted code was purely self-referential. Diffs - 3rdparty/libprocess/src/subprocess_windows.cpp 1a91fbe7aeb44174ccfa2e7e299bc7dd52a11b8a Diff: https://reviews.apache.org/r/66429/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
