Re: Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes.

2018-04-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66574/#review201057
---


Ship it!




Ship It!

- Jie Yu


On April 12, 2018, 1:33 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66574/
> ---
> 
> (Updated April 12, 2018, 1:33 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8777
> https://issues.apache.org/jira/browse/MESOS-8777
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> To support the `STAGE_UNSTAGE_VOLUME` in CSI v0.2, a CSI volume is now
> staged at `/csi///mounts//staging` and
> mounted at `/csi///mounts//target`.
> 
> The `DiskInfo.Source.Path.root` and `DiskInfo.Source.Mount.root` fields
> now stores `./csi///mounts` for PATH and MOUNT disk
> resources respectively, and the actual mount point is carved out from
> the `root` and `id` fields. In the future, the `SharedInfo` might also
> be used to construct the mount point for shared volumes.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
>   src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
>   src/csi/paths.hpp 7892e5ed8d333be5e61e2148860789786db31925 
>   src/csi/paths.cpp 0d42db249c8c27b1089e91e8d068fb7fa81a46b3 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
>   src/slave/paths.cpp 8a7e162ad41f5e7cc73eda660c6adc365a73edba 
> 
> 
> Diff: https://reviews.apache.org/r/66574/diff/1/
> 
> 
> Testing
> ---
> 
> This patch cannot be compiled standalone. Tests done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 66574: Updated filesystem layout for staging and mounting CSI volumes.

2018-04-11 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66574/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

To support the `STAGE_UNSTAGE_VOLUME` in CSI v0.2, a CSI volume is now
staged at `/csi///mounts//staging` and
mounted at `/csi///mounts//target`.

The `DiskInfo.Source.Path.root` and `DiskInfo.Source.Mount.root` fields
now stores `./csi///mounts` for PATH and MOUNT disk
resources respectively, and the actual mount point is carved out from
the `root` and `id` fields. In the future, the `SharedInfo` might also
be used to construct the mount point for shared volumes.


Diffs
-

  src/CMakeLists.txt 6fc45dba8ee70b591be03ac483655c1844a0a6b9 
  src/Makefile.am 257ff0e8d21e5240c27a123ed0cd563214e24fce 
  src/csi/paths.hpp 7892e5ed8d333be5e61e2148860789786db31925 
  src/csi/paths.cpp 0d42db249c8c27b1089e91e8d068fb7fa81a46b3 
  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 
  src/slave/paths.cpp 8a7e162ad41f5e7cc73eda660c6adc365a73edba 


Diff: https://reviews.apache.org/r/66574/diff/1/


Testing
---

This patch cannot be compiled standalone. Tests done later in the chain.


Thanks,

Chun-Hung Hsiao