Re: Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66575/#review201059
---


Fix it, then Ship it!





src/resource_provider/storage/provider.cpp
Lines 2237-2244 (patched)


Ditto. Let's move to the caller.


- Jie Yu


On April 12, 2018, 1:35 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66575/
> ---
> 
> (Updated April 12, 2018, 1:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8777
> https://issues.apache.org/jira/browse/MESOS-8777
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The storage local resource provider now properly calls `NodeStageVolume`
> or `NodeUnstageVolume` when publishing or deleting volumes for CSI
> plugins support the `STAGE_UNSTAGE_VOLUME` capability.
> 
> 
> Diffs
> -
> 
>   src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
>   src/resource_provider/storage/provider.cpp 
> a07620d1c4bf618f669575b3e183bf598da905a6 
> 
> 
> Diff: https://reviews.apache.org/r/66575/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> `STAGE_UNSTAGE_VOLUME` is tested later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Review Request 66575: Supported `STAGE_UNSTAGE_VOLUME` CSI node capability in SLRP.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66575/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

The storage local resource provider now properly calls `NodeStageVolume`
or `NodeUnstageVolume` when publishing or deleting volumes for CSI
plugins support the `STAGE_UNSTAGE_VOLUME` capability.


Diffs
-

  src/csi/state.proto 0373c8ad217998a54b06d483f94052bcf4293677 
  src/resource_provider/storage/provider.cpp 
a07620d1c4bf618f669575b3e183bf598da905a6 


Diff: https://reviews.apache.org/r/66575/diff/1/


Testing
---

sudo make check

`STAGE_UNSTAGE_VOLUME` is tested later in the chain.


Thanks,

Chun-Hung Hsiao