Re: Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin.

2018-04-12 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66576/#review201062
---


Ship it!




Ship It!

- Jie Yu


On April 12, 2018, 1:36 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66576/
> ---
> 
> (Updated April 12, 2018, 1:36 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-8777
> https://issues.apache.org/jira/browse/MESOS-8777
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Now it is required to call `NodeStageVolume` before `NodePublishVolume`
> for the test CSI plugin. `NodeStageVolume` would bind-mount the volume
> directory to the specified staging path, and then `NodePublishVolume`
> would bind-mount the staging path to the target path.
> 
> 
> Diffs
> -
> 
>   src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19 
> 
> 
> Diff: https://reviews.apache.org/r/66576/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 66576: Added `STAGE_UNSTAGE_VOLUME` capability to the test CSI plugin.

2018-04-11 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66576/
---

Review request for mesos, Benjamin Bannier and Jie Yu.


Bugs: MESOS-8717
https://issues.apache.org/jira/browse/MESOS-8717


Repository: mesos


Description
---

Now it is required to call `NodeStageVolume` before `NodePublishVolume`
for the test CSI plugin. `NodeStageVolume` would bind-mount the volume
directory to the specified staging path, and then `NodePublishVolume`
would bind-mount the staging path to the target path.


Diffs
-

  src/examples/test_csi_plugin.cpp aed22623b6dadb791eeaac2ecde4c31236a5fc19 


Diff: https://reviews.apache.org/r/66576/diff/1/


Testing
---

sudo make check


Thanks,

Chun-Hung Hsiao