Re: Review Request 66591: Added a validation that `max_completion_time` must be non-negative.

2018-04-23 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66591/
---

(Updated April 23, 2018, 3:17 p.m.)


Review request for mesos, Jason Lai and James Peach.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

Added a validation that `max_completion_time` must be non-negative.


Diffs (updated)
-

  src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66591/diff/3/

Changes: https://reviews.apache.org/r/66591/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66591: Added a validation that `max_completion_time` must be non-negative.

2018-04-13 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66591/#review201114
---


Fix it, then Ship it!





src/master/validation.cpp
Lines 1320 (patched)


Too many newlines :)


- James Peach


On April 12, 2018, 9:20 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66591/
> ---
> 
> (Updated April 12, 2018, 9:20 p.m.)
> 
> 
> Review request for mesos, Jason Lai and James Peach.
> 
> 
> Bugs: MESOS-8725
> https://issues.apache.org/jira/browse/MESOS-8725
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a validation that `max_completion_time` must be non-negative.
> 
> 
> Diffs
> -
> 
>   src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66591/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Review Request 66591: Added a validation that `max_completion_time` must be non-negative.

2018-04-12 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66591/
---

Review request for mesos, Jason Lai and James Peach.


Bugs: MESOS-8725
https://issues.apache.org/jira/browse/MESOS-8725


Repository: mesos


Description
---

Added a validation that `max_completion_time` must be non-negative.


Diffs
-

  src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf 
  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66591/diff/1/


Testing
---


Thanks,

Zhitao Li