Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review202216 --- Ship it! Ship It! - Joseph Wu On April 16, 2018, 1:24 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66641/ > --- > > (Updated April 16, 2018, 1:24 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added `FsTest.Open` to cover `os::open()`. > > > Diffs > - > > 3rdparty/stout/tests/os/filesystem_tests.cpp > c190baa2230298e428d4034b90dccffb59b4e710 > > > Diff: https://reviews.apache.org/r/66641/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review202129 --- Ship it! Ship It! - Akash Gupta On April 16, 2018, 8:24 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66641/ > --- > > (Updated April 16, 2018, 8:24 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added `FsTest.Open` to cover `os::open()`. > > > Diffs > - > > 3rdparty/stout/tests/os/filesystem_tests.cpp > c190baa2230298e428d4034b90dccffb59b4e710 > > > Diff: https://reviews.apache.org/r/66641/diff/2/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review201277 --- Patch looks great! Reviews applied: [66420, 66421, 66422, 66423, 66424, 66425, 66426, 66427, 66428, 66455, 66429, 66430, 66431, 66432, 66434, 66435, 66436, 66437, 66433, 66438, 66439, 66440, 66442, 66443, 66444, 66445, 66578, 66641] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 16, 2018, 1:24 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66641/ > --- > > (Updated April 16, 2018, 1:24 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added `FsTest.Open` to cover `os::open()`. > > > Diffs > - > > 3rdparty/stout/tests/os/filesystem_tests.cpp > c190baa2230298e428d4034b90dccffb59b4e710 > > > Diff: https://reviews.apache.org/r/66641/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66641: Added `FsTest.Open` to cover `os::open()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/#review201263 --- PASS: Mesos patch 66641 was successfully built and tested. Reviews applied: `['66423', '66424', '66425', '66426', '66427', '66428', '66455', '66429', '66430', '66431', '66432', '66434', '66435', '66436', '66437', '66433', '66438', '66439', '66440', '66442', '66443', '66444', '66445', '66578', '66641']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66641 - Mesos Reviewbot Windows On April 16, 2018, 1:24 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66641/ > --- > > (Updated April 16, 2018, 1:24 p.m.) > > > Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > --- > > Added `FsTest.Open` to cover `os::open()`. > > > Diffs > - > > 3rdparty/stout/tests/os/filesystem_tests.cpp > c190baa2230298e428d4034b90dccffb59b4e710 > > > Diff: https://reviews.apache.org/r/66641/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Review Request 66641: Added `FsTest.Open` to cover `os::open()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66641/ --- Review request for mesos, Akash Gupta, John Kordich, and Joseph Wu. Repository: mesos Description --- Added `FsTest.Open` to cover `os::open()`. Diffs - 3rdparty/stout/tests/os/filesystem_tests.cpp c190baa2230298e428d4034b90dccffb59b4e710 Diff: https://reviews.apache.org/r/66641/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
