Re: Review Request 66692: Fixed an documentation error in `monitoring.md`.

2018-04-23 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66692/#review201774
---


Ship it!




Ship It!

- Benjamin Mahler


On April 18, 2018, 5:37 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66692/
> ---
> 
> (Updated April 18, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See diff.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 12e2103eb041e3e1b99bddafafcf4c615205fb0c 
> 
> 
> Diff: https://reviews.apache.org/r/66692/diff/1/
> 
> 
> Testing
> ---
> 
> Not needed.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66692: Fixed an documentation error in `monitoring.md`.

2018-04-18 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66692/#review201461
---



Patch looks great!

Reviews applied: [66692]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 18, 2018, 5:37 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66692/
> ---
> 
> (Updated April 18, 2018, 5:37 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See diff.
> 
> 
> Diffs
> -
> 
>   docs/monitoring.md 12e2103eb041e3e1b99bddafafcf4c615205fb0c 
> 
> 
> Diff: https://reviews.apache.org/r/66692/diff/1/
> 
> 
> Testing
> ---
> 
> Not needed.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 66692: Fixed an documentation error in `monitoring.md`.

2018-04-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66692/#review201435
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66692']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66692

Relevant logs:

- 
[libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66692/logs/libprocess-tests-cmake-stdout.log):

```
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(499):
 warning C4244: '=': conversion from 'int64_t' to 'long', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\evutil_time.c(504):
 warning C4244: '=': conversion from 'time_t' to 'long', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(185):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(230):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(587):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(598):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(654):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(656):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(675):
 warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(755):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(763):
 warning C4244: '=': conversion from 'SSIZE_T' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(874):
 warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]
 [D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta.vcxproj]
 
d:\dcos\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta\bufferevent_openssl.c(1275):
 warning C4244: 'function': conversion from 'intptr_t' to 'int', possible loss 
of data 
[D:\DCOS\mesos\3rdparty\libevent-2.1.5-beta\src\libevent-2.1.5-beta-build\event_extra.vcxproj]

Review Request 66692: Fixed an documentation error in `monitoring.md`.

2018-04-18 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66692/
---

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
---

See diff.


Diffs
-

  docs/monitoring.md 12e2103eb041e3e1b99bddafafcf4c615205fb0c 


Diff: https://reviews.apache.org/r/66692/diff/1/


Testing
---

Not needed.


Thanks,

Meng Zhu