Re: Review Request 66939: Improved validation messages for some operations.

2018-05-07 Thread Jan Schlicht 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202548
---


Ship it!




Ship It!

- Jan Schlicht


On May 5, 2018, 1:41 a.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66939/
> ---
> 
> (Updated May 5, 2018, 1:41 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved validation messages for some operations.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 0c1c9249a0c1ca5ca52e5d7f32a1f02f6e2078d1 
>   src/tests/master_validation_tests.cpp 
> fb1d8bdf9ba09cace3ceb202dc70c0d201f2784e 
> 
> 
> Diff: https://reviews.apache.org/r/66939/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-05 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202519
---



Patch looks great!

Reviews applied: [66939]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 4, 2018, 4:41 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66939/
> ---
> 
> (Updated May 4, 2018, 4:41 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved validation messages for some operations.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp 0c1c9249a0c1ca5ca52e5d7f32a1f02f6e2078d1 
>   src/tests/master_validation_tests.cpp 
> fb1d8bdf9ba09cace3ceb202dc70c0d201f2784e 
> 
> 
> Diff: https://reviews.apache.org/r/66939/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-04 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202514
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66939']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66939

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66939/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (121 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1106 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (36 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (756 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (783 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (728 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (755 ms total)

[--] Global test environment tear-down
[==] 978 tests from 95 test cases ran. (442853 ms total)
[  PASSED  ] 977 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] 
ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.SigkillExecutor/0, 
where GetParam() = "docker,mesos"

 1 FAILED TEST
  YOU HAVE 219 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66939/logs/mesos-tests-stderr.log):

```
I0505 02:24:29.888206 12916 master.cpp:10820] Updating the state of task 
b1f57839-7595-497a-b1b6-01815b07ef24 of framework 
40e763f7-4f68-4143-afd0-0f12a8e4775c- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0505 02:24:29.888206 11332 slave.cpp:3935] Shutting down framework 
40e763f7-4f68-4143-afd0-0f12a8e4775c-
I0505 02:24:29.888206 11332 sI0505 02:24:29.718236  6800 exec.cpp:162] Version: 
1.6.0
I0505 02:24:29.744251 10512 exec.cpp:236] Executor registered on agent 
40e763f7-4f68-4143-afd0-0f12a8e4775c-S0
I0505 02:24:29.748239  9220 executor.cpp:178] Received SUBSCRIBED event
I0505 02:24:29.753237  9220 executor.cpp:182] Subscribed executor on 
winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0505 02:24:29.753237  9220 executor.cpp:178] Received LAUNCH event
I0505 02:24:29.759203  9220 executor.cpp:665] Starting task 
b1f57839-7595-497a-b1b6-01815b07ef24
I0505 02:24:29.849251  9220 executor.cpp:485] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0505 02:24:29.863219  9220 executor.cpp:678] Forked command at 12556
I0505 02:24:29.890205 15192 exec.cpp:445] Executor asked to shutdown
I0505 02:24:29.891204  7876 executor.cpp:178] Received SHUTDOWN event
I0505 02:24:29.891204  7876 executor.cpp:781] Shutting down
I0505 02:24:29.891204  7876 executor.cpp:894] Sending SIGTERM to process tree 
at pid lave.cpp:6656] Shutting down executor 
'b1f57839-7595-497a-b1b6-01815b07ef24' of framework 
40e763f7-4f68-4143-afd0-0f12a8e4775c- at executor(1)@10.3.1.5:56470
I0505 02:24:29.890205 11332 slave.cpp:929] Agent terminating
I0505 02:24:29.890205 12916 master.cpp:10919] Removing task 
b1f57839-7595-497a-b1b6-01815b07ef24 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 40e763f7-4f68-4143-afd0-0f12a8e4775c- on 
agent 40e763f7-4f68-4143-afd0-0f12a8e4775c-S0 at slave(443)@10.3.1.5:56449 
(winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
W0505 02:24:29.890205 11332 slave.cpp:3931] Ignoring shutdown framework 
40e763f7-4f68-4143-afd0-0f12a8e4775c- because it is terminating
I0505 02:24:29.894217  9376 master.cpp:1293] Agent 
40e763f7-4f68-4143-afd0-0f12a8e4775c-S0 at slave(443)@10.3.1.5:56449 
(winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0505 02:24:29.894217  9376 master.cpp:3299] Disconnecting agent 
40e763f7-4f68-4143-afd0-0f12a8e4775c-S0 at slave(443)@10.3.1.5:56449 
(winbldsrv-02.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0505 02:24:29.895225 10312 hierarchical.cpp:344] Removed framework 
40e763f7-4f68-4143-afd0-0f12a8e4775c-
I0505 02:24:29.895225  9376 master.cpp:3318] Deactivating agent

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-04 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/
---

(Updated May 4, 2018, 4:41 p.m.)


Review request for mesos, Greg Mann and Jan Schlicht.


Changes
---

Fixed tests.


Repository: mesos


Description
---

Improved validation messages for some operations.


Diffs (updated)
-

  src/master/validation.cpp 0c1c9249a0c1ca5ca52e5d7f32a1f02f6e2078d1 
  src/tests/master_validation_tests.cpp 
fb1d8bdf9ba09cace3ceb202dc70c0d201f2784e 


Diff: https://reviews.apache.org/r/66939/diff/3/

Changes: https://reviews.apache.org/r/66939/diff/2-3/


Testing
---


Thanks,

Gaston Kleiman

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-03 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202399
---



PASS: Mesos patch 66939 was successfully built and tested.

Reviews applied: `['66939']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66939

- Mesos Reviewbot Windows


On May 3, 2018, 11:54 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66939/
> ---
> 
> (Updated May 3, 2018, 11:54 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved validation messages for some operations.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66939/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-03 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/
---

(Updated May 3, 2018, 4:54 p.m.)


Review request for mesos, Greg Mann and Jan Schlicht.


Changes
---

Addressed Greg's feedback. I guess I need new glasses ¯\_(?)_/¯.


Repository: mesos


Description
---

Improved validation messages for some operations.


Diffs (updated)
-

  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66939/diff/2/

Changes: https://reviews.apache.org/r/66939/diff/1-2/


Testing
---


Thanks,

Gaston Kleiman

Re: Review Request 66939: Improved validation messages for some operations.

2018-05-03 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/#review202390
---


Fix it, then Ship it!





src/master/validation.cpp
Line 2368 (original), 2368 (patched)


Nit: let's be consistent with backticks or quotes. Looks like quotes may be 
more consistent with existing messages?


- Greg Mann


On May 3, 2018, 10:36 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66939/
> ---
> 
> (Updated May 3, 2018, 10:36 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improved validation messages for some operations.
> 
> 
> Diffs
> -
> 
>   src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 
> 
> 
> Diff: https://reviews.apache.org/r/66939/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>

Review Request 66939: Improved validation messages for some operations.

2018-05-03 Thread Gaston Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66939/
---

Review request for mesos, Greg Mann and Jan Schlicht.


Repository: mesos


Description
---

Improved validation messages for some operations.


Diffs
-

  src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d 


Diff: https://reviews.apache.org/r/66939/diff/1/


Testing
---


Thanks,

Gaston Kleiman