Re: Review Request 66940: Documented the changes in the agent flags and modules.

2018-05-04 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66940/#review202471
---


Ship it!




Ship It!

- Greg Mann


On May 3, 2018, 10:38 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66940/
> ---
> 
> (Updated May 3, 2018, 10:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the changes in the agent flags and modules.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 2de8900d4a7d192fad959da8a1b6929067a6bfc9 
> 
> 
> Diff: https://reviews.apache.org/r/66940/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested if the hyperlinks work ;) No test is needed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Re: Review Request 66940: Documented the changes in the agent flags and modules.

2018-05-03 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66940/#review202411
---



PASS: Mesos patch 66940 was successfully built and tested.

Reviews applied: `['66940']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66940

- Mesos Reviewbot Windows


On May 3, 2018, 10:38 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66940/
> ---
> 
> (Updated May 3, 2018, 10:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the changes in the agent flags and modules.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 2de8900d4a7d192fad959da8a1b6929067a6bfc9 
> 
> 
> Diff: https://reviews.apache.org/r/66940/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested if the hyperlinks work ;) No test is needed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Re: Review Request 66940: Documented the changes in the agent flags and modules.

2018-05-03 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66940/#review202400
---



Patch looks great!

Reviews applied: [66893, 66894, 66896, 66940]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 3, 2018, 10:38 p.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66940/
> ---
> 
> (Updated May 3, 2018, 10:38 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented the changes in the agent flags and modules.
> 
> 
> Diffs
> -
> 
>   docs/upgrades.md 2de8900d4a7d192fad959da8a1b6929067a6bfc9 
> 
> 
> Diff: https://reviews.apache.org/r/66940/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested if the hyperlinks work ;) No test is needed.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>



Review Request 66940: Documented the changes in the agent flags and modules.

2018-05-03 Thread Chun-Hung Hsiao

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66940/
---

Review request for mesos, Gilbert Song, Greg Mann, and Jie Yu.


Repository: mesos


Description
---

Documented the changes in the agent flags and modules.


Diffs
-

  docs/upgrades.md 2de8900d4a7d192fad959da8a1b6929067a6bfc9 


Diff: https://reviews.apache.org/r/66940/diff/1/


Testing
---

Manually tested if the hyperlinks work ;) No test is needed.


Thanks,

Chun-Hung Hsiao