Re: Review Request 67208: Windows: Updated information on docker health checks.

2018-05-22 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67208/#review203613
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 18, 2018, 2:08 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67208/
> ---
> 
> (Updated May 18, 2018, 2:08 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and 
> Gaston Kleiman.
> 
> 
> Bugs: MESOS-8499
> https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous commit changed how the health checks work on Windows,
> so this commit updates the documentation to reflect on those changes.
> 
> 
> Diffs
> -
> 
>   docs/health-checks.md c6f7144e9f62bf38799e1c66297f405be6fd5b30 
> 
> 
> Diff: https://reviews.apache.org/r/67208/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 67208: Windows: Updated information on docker health checks.

2018-05-18 Thread Andrew Schwartzmeyer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67208/#review203429
---




docs/health-checks.md
Lines 565-581 (patched)


This is great; but is there anything stopping us from creating exactly this 
image and putting it on Docker hub, and then using it as the default if the 
environment variable is unspecified?


- Andrew Schwartzmeyer


On May 18, 2018, 2:08 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67208/
> ---
> 
> (Updated May 18, 2018, 2:08 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and 
> Gaston Kleiman.
> 
> 
> Bugs: MESOS-8499
> https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous commit changed how the health checks work on Windows,
> so this commit updates the documentation to reflect on those changes.
> 
> 
> Diffs
> -
> 
>   docs/health-checks.md c6f7144e9f62bf38799e1c66297f405be6fd5b30 
> 
> 
> Diff: https://reviews.apache.org/r/67208/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Re: Review Request 67208: Windows: Updated information on docker health checks.

2018-05-18 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67208/#review203406
---



PASS: Mesos patch 67208 was successfully built and tested.

Reviews applied: `['67207', '67208']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67208

- Mesos Reviewbot Windows


On May 18, 2018, 9:08 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67208/
> ---
> 
> (Updated May 18, 2018, 9:08 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and 
> Gaston Kleiman.
> 
> 
> Bugs: MESOS-8499
> https://issues.apache.org/jira/browse/MESOS-8499
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The previous commit changed how the health checks work on Windows,
> so this commit updates the documentation to reflect on those changes.
> 
> 
> Diffs
> -
> 
>   docs/health-checks.md c6f7144e9f62bf38799e1c66297f405be6fd5b30 
> 
> 
> Diff: https://reviews.apache.org/r/67208/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>

Review Request 67208: Windows: Updated information on docker health checks.

2018-05-18 Thread Akash Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67208/
---

Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and Gaston 
Kleiman.


Bugs: MESOS-8499
https://issues.apache.org/jira/browse/MESOS-8499


Repository: mesos


Description
---

The previous commit changed how the health checks work on Windows,
so this commit updates the documentation to reflect on those changes.


Diffs
-

  docs/health-checks.md c6f7144e9f62bf38799e1c66297f405be6fd5b30 


Diff: https://reviews.apache.org/r/67208/diff/1/


Testing
---


Thanks,

Akash Gupta