Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 13, 2018, 6:36 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Changes
---

Rebase


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/5/

Changes: https://reviews.apache.org/r/67287/diff/4-5/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review204717
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On June 12, 2018, 3:56 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67287/
> ---
> 
> (Updated June 12, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
> Yu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
> 
> 
> Diff: https://reviews.apache.org/r/67287/diff/4/
> 
> 
> Testing
> ---
> 
> All Mesos-tests
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 12, 2018, 10:56 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/4/

Changes: https://reviews.apache.org/r/67287/diff/3-4/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated June 12, 2018, 9:07 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/3/

Changes: https://reviews.apache.org/r/67287/diff/2-3/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review204547
---


Fix it, then Ship it!





3rdparty/libprocess/include/process/subprocess.hpp
Lines 383 (patched)


`= {}` to match the rest of the parameters



3rdparty/libprocess/include/process/subprocess.hpp
Lines 420 (patched)


Ditto



3rdparty/libprocess/src/subprocess_windows.hpp
Lines 55 (patched)


Ditto


- Andrew Schwartzmeyer


On May 24, 2018, 3:47 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67287/
> ---
> 
> (Updated May 24, 2018, 3:47 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
> Yu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
> 
> 
> Diff: https://reviews.apache.org/r/67287/diff/2/
> 
> 
> Testing
> ---
> 
> All Mesos-tests
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Akash Gupta]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review204522
---


Ship it!




Ship It!

- Akash Gupta


On May 24, 2018, 10:47 p.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67287/
> ---
> 
> (Updated May 24, 2018, 10:47 p.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
> Yu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> White list fds that child processes can inherit in libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
> 
> 
> Diff: https://reviews.apache.org/r/67287/diff/2/
> 
> 
> Testing
> ---
> 
> All Mesos-tests
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated May 24, 2018, 10:47 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description (updated)
---

White list fds that child processes can inherit in libprocess.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/2/

Changes: https://reviews.apache.org/r/67287/diff/1-2/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/#review203800
---



Please fix up the commit message.

- Andrew Schwartzmeyer


On May 24, 2018, 11:43 a.m., Radhika Jandhyala wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67287/
> ---
> 
> (Updated May 24, 2018, 11:43 a.m.)
> 
> 
> Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
> Yu, Li Li, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8926
> https://issues.apache.org/jira/browse/MESOS-8926
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Libprocess: White list fds that child processes can inherit.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> 6a1262340c333b617402637e648c12769827ffc4 
>   3rdparty/libprocess/src/subprocess.cpp 
> d7a725363251f9c54072cd7551f5598696938308 
>   3rdparty/libprocess/src/subprocess_windows.hpp 
> c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 
> 
> 
> Diff: https://reviews.apache.org/r/67287/diff/1/
> 
> 
> Testing
> ---
> 
> All Mesos-tests
> 
> 
> Thanks,
> 
> Radhika Jandhyala
> 
>

Re: Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

(Updated May 24, 2018, 6:43 p.m.)


Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Eric Mumau, Jie 
Yu, Li Li, and Radhika Jandhyala.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description (updated)
---

Libprocess: White list fds that child processes can inherit.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/1/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala

Review Request 67287: White list fds that child processes can inherit in libprocess.

[Radhika Jandhyala via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67287/
---

Review request for mesos and Andrew Schwartzmeyer.


Bugs: MESOS-8926
https://issues.apache.org/jira/browse/MESOS-8926


Repository: mesos


Description
---

White list fds that child processes can inherit in libprocess.


Diffs
-

  3rdparty/libprocess/include/process/subprocess.hpp 
6a1262340c333b617402637e648c12769827ffc4 
  3rdparty/libprocess/src/subprocess.cpp 
d7a725363251f9c54072cd7551f5598696938308 
  3rdparty/libprocess/src/subprocess_windows.hpp 
c7ed0ad18f5b46a1d5ac2a6e51883aefb7c1692f 


Diff: https://reviews.apache.org/r/67287/diff/1/


Testing
---

All Mesos-tests


Thanks,

Radhika Jandhyala