Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203907 --- Ship it! Ship It! - Joseph Wu On May 24, 2018, 7:52 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67313/ > --- > > (Updated May 24, 2018, 7:52 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran > in a drive other than `C:`, since only `C:` exists in the docker > container with the default settings. The test was changed to hardcode > the `C:` drive on Windows. > > > Diffs > - > > src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf > > > Diff: https://reviews.apache.org/r/67313/diff/1/ > > > Testing > --- > > Waiting on CI to confirm that this fixes the issue there. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203900 --- Patch looks great! Reviews applied: [67313] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 25, 2018, 2:52 a.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67313/ > --- > > (Updated May 25, 2018, 2:52 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran > in a drive other than `C:`, since only `C:` exists in the docker > container with the default settings. The test was changed to hardcode > the `C:` drive on Windows. > > > Diffs > - > > src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf > > > Diff: https://reviews.apache.org/r/67313/diff/1/ > > > Testing > --- > > Waiting on CI to confirm that this fixes the issue there. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/#review203846 --- PASS: Mesos patch 67313 was successfully built and tested. Reviews applied: `['67313']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67313 - Mesos Reviewbot Windows On May 25, 2018, 2:52 a.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67313/ > --- > > (Updated May 25, 2018, 2:52 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran > in a drive other than `C:`, since only `C:` exists in the docker > container with the default settings. The test was changed to hardcode > the `C:` drive on Windows. > > > Diffs > - > > src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf > > > Diff: https://reviews.apache.org/r/67313/diff/1/ > > > Testing > --- > > Waiting on CI to confirm that this fixes the issue there. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67313/#review203843
---
Ship it!
Brilliant find.
First question that came to my mind was: why, then, did it work under a
debugger on Radhika's machine, but not otherwise?
But I think I know the answer: I'm guessing that when using Visual Studio to
launch the debug session, it was building its own copy in a default place (on
`C:`), since the CMake support in VS defaults to like `C:...\${workspaceHash}`.
And otherwise on the CLI she was building out of `D:\git\mesos` etc.
- Andrew Schwartzmeyer
On May 24, 2018, 7:52 p.m., Akash Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67313/
> ---
>
> (Updated May 24, 2018, 7:52 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran
> in a drive other than `C:`, since only `C:` exists in the docker
> container with the default settings. The test was changed to hardcode
> the `C:` drive on Windows.
>
>
> Diffs
> -
>
> src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf
>
>
> Diff: https://reviews.apache.org/r/67313/diff/1/
>
>
> Testing
> ---
>
> Waiting on CI to confirm that this fixes the issue there.
>
>
> Thanks,
>
> Akash Gupta
>
>
Review Request 67313: Windows: Fixed `ROOT_DOCKER_DockerHealthStatusChange` test.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67313/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: mesos Description --- The `ROOT_DOCKER_DockerHealthStatusChange` was broken if the test ran in a drive other than `C:`, since only `C:` exists in the docker container with the default settings. The test was changed to hardcode the `C:` drive on Windows. Diffs - src/tests/health_check_tests.cpp 7e8f86c903dfad73c2102eaf491fb2adcb7c11cf Diff: https://reviews.apache.org/r/67313/diff/1/ Testing --- Thanks, Akash Gupta
