Re: Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.

2018-06-08 Thread Andrew Schwartzmeyer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67392/#review204505
---


Ship it!




Ship It!

- Andrew Schwartzmeyer


On May 30, 2018, 11:41 a.m., Akash Gupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67392/
> ---
> 
> (Updated May 30, 2018, 11:41 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
> John Kordich, Joseph Wu, and Radhika Jandhyala.
> 
> 
> Bugs: MESOS-8668
> https://issues.apache.org/jira/browse/MESOS-8668
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> THe PipeLargeOutput test was calling `io::read`, which was returning the
> wrong error since it operates at a higher level abstraction. The test
> really just checks if a pipe EOF returns `ERROR_BROKEN_PIPE`, so the
> test was changed to use the lower level `os::read`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 568d77b94b3afef8c1ebdde71e14aa0b498da5c8 
> 
> 
> Diff: https://reviews.apache.org/r/67392/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Akash Gupta
> 
>



Review Request 67392: Windows: Made PipeLargeOutput test work with IOCP backend.

2018-05-30 Thread Akash Gupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67392/
---

Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, 
John Kordich, Joseph Wu, and Radhika Jandhyala.


Bugs: MESOS-8668
https://issues.apache.org/jira/browse/MESOS-8668


Repository: mesos


Description
---

THe PipeLargeOutput test was calling `io::read`, which was returning the
wrong error since it operates at a higher level abstraction. The test
really just checks if a pipe EOF returns `ERROR_BROKEN_PIPE`, so the
test was changed to use the lower level `os::read`.


Diffs
-

  3rdparty/libprocess/src/tests/subprocess_tests.cpp 
568d77b94b3afef8c1ebdde71e14aa0b498da5c8 


Diff: https://reviews.apache.org/r/67392/diff/1/


Testing
---


Thanks,

Akash Gupta