Re: Review Request 67395: Fixed socket creation bug in docker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204269 --- Ship it! Ship It! - Joseph Wu On May 30, 2018, 7:59 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67395/ > --- > > (Updated May 30, 2018, 7:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > On Windows, the statement `int_fd socket = ::socket(...);` would > implictly call the `WindowsFD(int crt)` constructor. Since that > contstructor only accepts values of {0, 1, 2}, it would incorrectly > mark the socket as invalid. The code has been changed to use the stout > network functions, which properly construct the `int_fd`. > > > Diffs > - > > src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 > > > Diff: https://reviews.apache.org/r/67395/diff/1/ > > > Testing > --- > > This bug was found when testing recovery in our Windows cluster and this > patch was confirmed to fix it. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67395: Fixed socket creation bug in docker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204162 --- Patch looks great! Reviews applied: [67395] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 31, 2018, 2:59 a.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67395/ > --- > > (Updated May 31, 2018, 2:59 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > On Windows, the statement `int_fd socket = ::socket(...);` would > implictly call the `WindowsFD(int crt)` constructor. Since that > contstructor only accepts values of {0, 1, 2}, it would incorrectly > mark the socket as invalid. The code has been changed to use the stout > network functions, which properly construct the `int_fd`. > > > Diffs > - > > src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 > > > Diff: https://reviews.apache.org/r/67395/diff/1/ > > > Testing > --- > > This bug was found when testing recovery in our Windows cluster and this > patch was confirmed to fix it. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67395: Fixed socket creation bug in docker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204105 --- PASS: Mesos patch 67395 was successfully built and tested. Reviews applied: `['67395']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67395 - Mesos Reviewbot Windows On May 30, 2018, 7:59 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67395/ > --- > > (Updated May 30, 2018, 7:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > On Windows, the statement `int_fd socket = ::socket(...);` would > implictly call the `WindowsFD(int crt)` constructor. Since that > contstructor only accepts values of {0, 1, 2}, it would incorrectly > mark the socket as invalid. The code has been changed to use the stout > network functions, which properly construct the `int_fd`. > > > Diffs > - > > src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 > > > Diff: https://reviews.apache.org/r/67395/diff/1/ > > > Testing > --- > > This bug was found when testing recovery in our Windows cluster and this > patch was confirmed to fix it. > > > Thanks, > > Akash Gupta > >
Re: Review Request 67395: Fixed socket creation bug in docker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/#review204102 --- Ship it! I really wish we'd been able to get rid of make explicit that constructor. I knew there'd be a bug like this. - Andrew Schwartzmeyer On May 30, 2018, 7:59 p.m., Akash Gupta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67395/ > --- > > (Updated May 30, 2018, 7:59 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. > > > Repository: mesos > > > Description > --- > > On Windows, the statement `int_fd socket = ::socket(...);` would > implictly call the `WindowsFD(int crt)` constructor. Since that > contstructor only accepts values of {0, 1, 2}, it would incorrectly > mark the socket as invalid. The code has been changed to use the stout > network functions, which properly construct the `int_fd`. > > > Diffs > - > > src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 > > > Diff: https://reviews.apache.org/r/67395/diff/1/ > > > Testing > --- > > This bug was found when testing recovery in our Windows cluster and this > patch was confirmed to fix it. > > > Thanks, > > Akash Gupta > >
Review Request 67395: Fixed socket creation bug in docker.cpp.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67395/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: mesos Description --- On Windows, the statement `int_fd socket = ::socket(...);` would implictly call the `WindowsFD(int crt)` constructor. Since that contstructor only accepts values of {0, 1, 2}, it would incorrectly mark the socket as invalid. The code has been changed to use the stout network functions, which properly construct the `int_fd`. Diffs - src/slave/containerizer/docker.cpp fc032367400119dc827657d0e6e859d18ebdbb16 Diff: https://reviews.apache.org/r/67395/diff/1/ Testing --- This bug was found when testing recovery in our Windows cluster and this patch was confirmed to fix it. Thanks, Akash Gupta