Re: Review Request 67510: Fixed a bug in `createStrippedScalarQuantity()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67510/#review205008 --- Ship it! Ship It! - Greg Mann On June 11, 2018, 5:30 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67510/ > --- > > (Updated June 11, 2018, 5:30 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Repository: mesos > > > Description > --- > > This patch fixes `createStrippedScalarQuantity()` by > stripping the revocable field in resources. > > Also added a test. > > > Diffs > - > > src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca > src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 > src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 > > > Diff: https://reviews.apache.org/r/67510/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Re: Review Request 67510: Fixed a bug in `createStrippedScalarQuantity()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67510/#review204554 --- PASS: Mesos patch 67510 was successfully built and tested. Reviews applied: `['67510']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67510 - Mesos Reviewbot Windows On June 11, 2018, 5:30 p.m., Meng Zhu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67510/ > --- > > (Updated June 11, 2018, 5:30 p.m.) > > > Review request for mesos, Gastón Kleiman and Greg Mann. > > > Repository: mesos > > > Description > --- > > This patch fixes `createStrippedScalarQuantity()` by > stripping the revocable field in resources. > > Also added a test. > > > Diffs > - > > src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca > src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 > src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 > > > Diff: https://reviews.apache.org/r/67510/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Meng Zhu > >
Review Request 67510: Fixed a bug in `createStrippedScalarQuantity()`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67510/ --- Review request for mesos, Gastón Kleiman and Greg Mann. Repository: mesos Description --- This patch fixes `createStrippedScalarQuantity()` by stripping the revocable field in resources. Also added a test. Diffs - src/common/resources.cpp b1392012702865e39d17b8715747582529cbccca src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 src/v1/resources.cpp 50793271ea9b3013aa5b4dcd95f329db81dff4d8 Diff: https://reviews.apache.org/r/67510/diff/1/ Testing --- make check Thanks, Meng Zhu
