Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205324
---


Ship it!




Ship It!

- Gilbert Song


On June 25, 2018, 6:56 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> ---
> 
> (Updated June 25, 2018, 6:56 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 81c934318dcc2bcc9df594af0ee25f0334541a65 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d146729123b85e46f580a594fb9f9ac37b542f7 
> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/5/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 25, 2018, 9:56 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Addressed review comments.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67526/diff/5/

Changes: https://reviews.apache.org/r/67526/diff/4-5/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Qian Zhang 


> On June 23, 2018, 8:21 a.m., Gilbert Song wrote:
> > src/launcher/executor.cpp
> > Lines 1281 (patched)
> > 
> >
> > Just bring this up: 
> > 
> > why don't we just call it `container_launch_info`, or 
> > `task_launch_info`?
> > 
> > I may prefer `task_launch_info` more, wdyt?

Agree.


> On June 23, 2018, 8:21 a.m., Gilbert Song wrote:
> > src/linux/fs.cpp
> > Lines 784 (patched)
> > 
> >
> > Could you remind me again how do we handle centos 6?

We will always do this mount for any supported platforms. So even cgroups are 
mounted under `/cgroup` in CentOS 6 host, we will still do the bind mount under 
`/sys/fs/cgroup` for the container launched on CentOS 6 host.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205256
---


On June 20, 2018, 10:48 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> ---
> 
> (Updated June 20, 2018, 10:48 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 81c934318dcc2bcc9df594af0ee25f0334541a65 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d146729123b85e46f580a594fb9f9ac37b542f7 
> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-25 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205273
---




src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 604-611 (patched)


Why do we need to read /proc/mount?

Couldn't we just iterate `subsystems` and `hierarchies` maps?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 611 (patched)


multihashmap supports `contains`, right?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 628 (patched)


s/symbol/symbolic/g?


- Gilbert Song


On June 19, 2018, 7:48 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> ---
> 
> (Updated June 19, 2018, 7:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 81c934318dcc2bcc9df594af0ee25f0334541a65 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d146729123b85e46f580a594fb9f9ac37b542f7 
> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-22 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205256
---




src/launcher/executor.cpp
Lines 1281 (patched)


Just bring this up: 

why don't we just call it `container_launch_info`, or `task_launch_info`?

I may prefer `task_launch_info` more, wdyt?



src/linux/fs.cpp
Lines 784 (patched)


Could you remind me again how do we handle centos 6?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 574 (patched)


const?


- Gilbert Song


On June 19, 2018, 7:48 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> ---
> 
> (Updated June 19, 2018, 7:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
> https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
> 81c934318dcc2bcc9df594af0ee25f0334541a65 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
> 6d146729123b85e46f580a594fb9f9ac37b542f7 
> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/4/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-19 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 20, 2018, 10:48 a.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
6d146729123b85e46f580a594fb9f9ac37b542f7 


Diff: https://reviews.apache.org/r/67526/diff/4/

Changes: https://reviews.apache.org/r/67526/diff/3-4/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-15 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 15, 2018, 7:53 p.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Changes
---

Only do container-specific cgroups mounts for container with rootfs.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67526/diff/3/

Changes: https://reviews.apache.org/r/67526/diff/2-3/


Testing
---


Thanks,

Qian Zhang

Re: Review Request 67526: Added container-specific cgroup FS mounts.

2018-06-12 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/
---

(Updated June 13, 2018, 10:42 a.m.)


Review request for mesos, Gilbert Song and Jason Lai.


Summary (updated)
-

Added container-specific cgroup FS mounts.


Bugs: MESOS-8327
https://issues.apache.org/jira/browse/MESOS-8327


Repository: mesos


Description
---

Added container-specific cgroup FS mounts.


Diffs (updated)
-

  src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 
81c934318dcc2bcc9df594af0ee25f0334541a65 
  src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 
215e32461e851668247f9fae62aa656f5dd5e245 


Diff: https://reviews.apache.org/r/67526/diff/2/

Changes: https://reviews.apache.org/r/67526/diff/1-2/


Testing
---


Thanks,

Qian Zhang