Re: Review Request 67541: Made `NoopResourceEstimator` return a forever-pending future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67541/#review204585 --- Ship it! Ship It! - Jie Yu On June 11, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67541/ > --- > > (Updated June 11, 2018, 11:51 p.m.) > > > Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Jie Yu. > > > Bugs: MESOS-8873 > https://issues.apache.org/jira/browse/MESOS-8873 > > > Repository: mesos > > > Description > --- > > There is no need for the noop resource estimator to return a ready > future of empty resource since it is only activated when the user > does not want to use an resource estimator. > > > Diffs > - > > src/slave/resource_estimators/noop.cpp > c3ddc0149b2545183a105eb2b9dd31488f40 > > > Diff: https://reviews.apache.org/r/67541/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 67541: Made `NoopResourceEstimator` return a forever-pending future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67541/#review204581 --- PASS: Mesos patch 67541 was successfully built and tested. Reviews applied: `['67541']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67541 - Mesos Reviewbot Windows On June 11, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67541/ > --- > > (Updated June 11, 2018, 11:51 p.m.) > > > Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Jie Yu. > > > Bugs: MESOS-8873 > https://issues.apache.org/jira/browse/MESOS-8873 > > > Repository: mesos > > > Description > --- > > There is no need for the noop resource estimator to return a ready > future of empty resource since it is only activated when the user > does not want to use an resource estimator. > > > Diffs > - > > src/slave/resource_estimators/noop.cpp > c3ddc0149b2545183a105eb2b9dd31488f40 > > > Diff: https://reviews.apache.org/r/67541/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Review Request 67541: Made `NoopResourceEstimator` return a forever-pending future.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67541/ --- Review request for mesos, Benjamin Bannier, Gastón Kleiman, and Jie Yu. Bugs: MESOS-8873 https://issues.apache.org/jira/browse/MESOS-8873 Repository: mesos Description --- There is no need for the noop resource estimator to return a ready future of empty resource since it is only activated when the user does not want to use an resource estimator. Diffs - src/slave/resource_estimators/noop.cpp c3ddc0149b2545183a105eb2b9dd31488f40 Diff: https://reviews.apache.org/r/67541/diff/1/ Testing --- sudo make check Thanks, Chun-Hung Hsiao
