Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-11 Thread Jacob Janco 


> On Oct. 10, 2018, 11:10 p.m., James Peach wrote:
> > include/mesos/allocator/allocator.hpp
> > Lines 47 (patched)
> > 
> >
> > This shouldn't be indented.

Done.


> On Oct. 10, 2018, 11:10 p.m., James Peach wrote:
> > include/mesos/allocator/allocator.hpp
> > Lines 57 (patched)
> > 
> >
> > I think that you can simplify this to:
> > ```C
> > struct Options
> > {
> >   Duration allocationInterval = Seconds();
> >   ...
> > };
> > ```

Makes sense. Done.


> On Oct. 10, 2018, 11:10 p.m., James Peach wrote:
> > src/master/allocator/mesos/allocator.hpp
> > Lines 29 (patched)
> > 
> >
> > Don't `use` names in headers, because it has side-effects on the files 
> > that include them.

Done.


> On Oct. 10, 2018, 11:10 p.m., James Peach wrote:
> > src/master/allocator/mesos/hierarchical.hpp
> > Lines 46 (patched)
> > 
> >
> > Don't `use` names in headers, because it has side-effects on the files 
> > that include them.

Done.


> On Oct. 10, 2018, 11:10 p.m., James Peach wrote:
> > src/master/master.cpp
> > Lines 758 (patched)
> > 
> >
> > Add a newline here.

Done.


- Jacob


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209421
---


On Oct. 10, 2018, 10:19 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 10, 2018, 10:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor allocator configuration into class.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> e09a615979014909e7b88d44e6617fd1476415c5 
>   src/master/allocator/mesos/hierarchical.cpp 
> 6f389ed46683f7c642e87b673dc15307cc2b5cd6 
>   src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/2/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/#review209421
---




include/mesos/allocator/allocator.hpp
Lines 47 (patched)


This shouldn't be indented.



include/mesos/allocator/allocator.hpp
Lines 57 (patched)


I think that you can simplify this to:
```C
struct Options
{
  Duration allocationInterval = Seconds();
  ...
};
```



src/master/allocator/mesos/allocator.hpp
Lines 29 (patched)


Don't `use` names in headers, because it has side-effects on the files that 
include them.



src/master/allocator/mesos/hierarchical.hpp
Lines 46 (patched)


Don't `use` names in headers, because it has side-effects on the files that 
include them.



src/master/master.cpp
Lines 758 (patched)


Add a newline here.


- James Peach


On Oct. 10, 2018, 10:19 p.m., Jacob Janco wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68953/
> ---
> 
> (Updated Oct. 10, 2018, 10:19 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.
> 
> 
> Bugs: MESOS-9301
> https://issues.apache.org/jira/browse/MESOS-9301
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactor allocator configuration into class.
> 
> 
> Diffs
> -
> 
>   include/mesos/allocator/allocator.hpp 
> 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
>   src/master/allocator/mesos/allocator.hpp 
> a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
>   src/master/allocator/mesos/hierarchical.hpp 
> e09a615979014909e7b88d44e6617fd1476415c5 
>   src/master/allocator/mesos/hierarchical.cpp 
> 6f389ed46683f7c642e87b673dc15307cc2b5cd6 
>   src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 
> 
> 
> Diff: https://reviews.apache.org/r/68953/diff/2/
> 
> 
> Testing
> ---
> 
> make check on OSX
> 
> 
> Thanks,
> 
> Jacob Janco
> 
>

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 10, 2018, 10:19 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

Refactor allocator configuration into class.


Diffs (updated)
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 


Diff: https://reviews.apache.org/r/68953/diff/2/

Changes: https://reviews.apache.org/r/68953/diff/1-2/


Testing (updated)
---

make check on OSX


Thanks,

Jacob Janco

Re: Review Request 68953: Refactor allocator configuration into class.

2018-10-10 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

(Updated Oct. 10, 2018, 9:55 p.m.)


Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach.


Bugs: MESOS-9301
https://issues.apache.org/jira/browse/MESOS-9301


Repository: mesos


Description
---

Refactor allocator configuration into class.


Diffs
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 


Diff: https://reviews.apache.org/r/68953/diff/1/


Testing
---


Thanks,

Jacob Janco

Review Request 68953: Refactor allocator configuration into class.

2018-10-08 Thread Jacob Janco 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68953/
---

Review request for mesos.


Repository: mesos


Description
---

Refactor allocator configuration into class.


Diffs
-

  include/mesos/allocator/allocator.hpp 
61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 
  src/master/allocator/mesos/allocator.hpp 
a4d7f2be3e8ff71cc2c45cb8ed808b9dbb821aaf 
  src/master/allocator/mesos/hierarchical.hpp 
e09a615979014909e7b88d44e6617fd1476415c5 
  src/master/allocator/mesos/hierarchical.cpp 
6f389ed46683f7c642e87b673dc15307cc2b5cd6 
  src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 


Diff: https://reviews.apache.org/r/68953/diff/1/


Testing
---


Thanks,

Jacob Janco