Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209707 --- Ship it! Ship It! - Benjamin Mahler On Oct. 16, 2018, 10:23 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69042/ > --- > > (Updated Oct. 16, 2018, 10:23 a.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > --- > > Since this class was explicitly declaring a constructor, no other > constructors such as copy or move constructors were generated. > > This patch removes the custom constructor so all default constructors > are generated automatically. This e.g., enables move construction of > `RegistryOperation` values. > > > Diffs > - > > src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 > > > Diff: https://reviews.apache.org/r/69042/diff/1/ > > > Testing > --- > > `make check` > > Without this patch a clang close to trunk would warn > ``` > ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted > move constructor is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move constructor of > 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move constructor > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy constructor of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy constructor > class RegistryOperation : public process::Promise > ^ > ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted > move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation& operator=(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator > of 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move assignment operator > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy assignment operator of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy assignment operator > class RegistryOperation : public process::Promise > ^ > 2 warnings generated. > ``` > > No warning is emitted with this patch. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209695 --- Patch looks great! Reviews applied: [69041, 69042] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Oct. 16, 2018, 10:23 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69042/ > --- > > (Updated Oct. 16, 2018, 10:23 a.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > --- > > Since this class was explicitly declaring a constructor, no other > constructors such as copy or move constructors were generated. > > This patch removes the custom constructor so all default constructors > are generated automatically. This e.g., enables move construction of > `RegistryOperation` values. > > > Diffs > - > > src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 > > > Diff: https://reviews.apache.org/r/69042/diff/1/ > > > Testing > --- > > `make check` > > Without this patch a clang close to trunk would warn > ``` > ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted > move constructor is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move constructor of > 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move constructor > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy constructor of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy constructor > class RegistryOperation : public process::Promise > ^ > ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted > move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation& operator=(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator > of 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move assignment operator > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy assignment operator of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy assignment operator > class RegistryOperation : public process::Promise > ^ > 2 warnings generated. > ``` > > No warning is emitted with this patch. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209686 --- Ship it! Ship It! - Jan Schlicht On Oct. 16, 2018, 12:23 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69042/ > --- > > (Updated Oct. 16, 2018, 12:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > --- > > Since this class was explicitly declaring a constructor, no other > constructors such as copy or move constructors were generated. > > This patch removes the custom constructor so all default constructors > are generated automatically. This e.g., enables move construction of > `RegistryOperation` values. > > > Diffs > - > > src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 > > > Diff: https://reviews.apache.org/r/69042/diff/1/ > > > Testing > --- > > `make check` > > Without this patch a clang close to trunk would warn > ``` > ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted > move constructor is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move constructor of > 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move constructor > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy constructor of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy constructor > class RegistryOperation : public process::Promise > ^ > ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted > move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation& operator=(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator > of 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move assignment operator > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy assignment operator of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy assignment operator > class RegistryOperation : public process::Promise > ^ > 2 warnings generated. > ``` > > No warning is emitted with this patch. > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 69042: Enabled more constructors for master `RegistryOperation`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/#review209614 --- PASS: Mesos patch 69042 was successfully built and tested. Reviews applied: `['69041', '69042']` All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2472/mesos-review-69042 - Mesos Reviewbot Windows On Oct. 16, 2018, 12:23 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69042/ > --- > > (Updated Oct. 16, 2018, 12:23 p.m.) > > > Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. > > > Repository: mesos > > > Description > --- > > Since this class was explicitly declaring a constructor, no other > constructors such as copy or move constructors were generated. > > This patch removes the custom constructor so all default constructors > are generated automatically. This e.g., enables move construction of > `RegistryOperation` values. > > > Diffs > - > > src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 > > > Diff: https://reviews.apache.org/r/69042/diff/1/ > > > Testing > --- > > `make check` > > Without this patch a clang close to trunk would warn > ``` > ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted > move constructor is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move constructor of > 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move constructor > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy constructor of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy constructor > class RegistryOperation : public process::Promise > ^ > ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted > move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] > AdaptedOperation& operator=(AdaptedOperation&&) = default; > ^ > ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator > of 'AdaptedOperation' is implicitly deleted because base class > 'master::RegistryOperation' has a deleted move assignment operator > class AdaptedOperation : public master::RegistryOperation >^ > ../src/master/registrar.hpp:45:27: note: copy assignment operator of > 'RegistryOperation' is implicitly deleted because base class > 'process::Promise' has an inaccessible copy assignment operator > class RegistryOperation : public process::Promise > ^ > 2 warnings generated. > ``` > > No warning is emitted with this patch. > > > Thanks, > > Benjamin Bannier > >
Review Request 69042: Enabled more constructors for master `RegistryOperation`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69042/ --- Review request for mesos, Benjamin Mahler and Chun-Hung Hsiao. Repository: mesos Description --- Since this class was explicitly declaring a constructor, no other constructors such as copy or move constructors were generated. This patch removes the custom constructor so all default constructors are generated automatically. This e.g., enables move construction of `RegistryOperation` values. Diffs - src/master/registrar.hpp 4f7c7ce2b3dea9f19eae67494f9767dc1c61e121 Diff: https://reviews.apache.org/r/69042/diff/1/ Testing --- `make check` Without this patch a clang close to trunk would warn ``` ../src/resource_provider/registrar.cpp:387:5: warning: explicitly defaulted move constructor is implicitly deleted [-Wdefaulted-function-deleted] AdaptedOperation(AdaptedOperation&&) = default; ^ ../src/resource_provider/registrar.cpp:374:28: note: move constructor of 'AdaptedOperation' is implicitly deleted because base class 'master::RegistryOperation' has a deleted move constructor class AdaptedOperation : public master::RegistryOperation ^ ../src/master/registrar.hpp:45:27: note: copy constructor of 'RegistryOperation' is implicitly deleted because base class 'process::Promise' has an inaccessible copy constructor class RegistryOperation : public process::Promise ^ ../src/resource_provider/registrar.cpp:389:23: warning: explicitly defaulted move assignment operator is implicitly deleted [-Wdefaulted-function-deleted] AdaptedOperation& operator=(AdaptedOperation&&) = default; ^ ../src/resource_provider/registrar.cpp:374:28: note: move assignment operator of 'AdaptedOperation' is implicitly deleted because base class 'master::RegistryOperation' has a deleted move assignment operator class AdaptedOperation : public master::RegistryOperation ^ ../src/master/registrar.hpp:45:27: note: copy assignment operator of 'RegistryOperation' is implicitly deleted because base class 'process::Promise' has an inaccessible copy assignment operator class RegistryOperation : public process::Promise ^ 2 warnings generated. ``` No warning is emitted with this patch. Thanks, Benjamin Bannier
