Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-26 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69394/#review210860
---


Ship it!




Ship It!

- Kevin Klues


On Nov. 25, 2018, 9:53 vorm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69394/
> ---
> 
> (Updated Nov. 25, 2018, 9:53 vorm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated 'mesos task list' to only display running tasks.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 4abc70a2de7e63bb629d5ed82d0045b29fb237fa 
>   src/python/cli_new/lib/cli/tests/task.py 
> 1b48c0a4729043c874330552074b05368e38b715 
> 
> 
> Diff: https://reviews.apache.org/r/69394/diff/2/
> 
> 
> Testing
> ---
> 
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 7 tests in 19.845s
> 
> OK
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-25 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69394/
---

(Updated Nov. 25, 2018, 10:53 a.m.)


Review request for mesos and Kevin Klues.


Changes
---

Fixed issue.


Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399


Repository: mesos


Description
---

Updated 'mesos task list' to only display running tasks.


Diffs (updated)
-

  src/python/cli_new/lib/cli/plugins/task/main.py 
4abc70a2de7e63bb629d5ed82d0045b29fb237fa 
  src/python/cli_new/lib/cli/tests/task.py 
1b48c0a4729043c874330552074b05368e38b715 


Diff: https://reviews.apache.org/r/69394/diff/2/

Changes: https://reviews.apache.org/r/69394/diff/1-2/


Testing
---

(mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok

--
Ran 7 tests in 19.845s

OK


Thanks,

Armand Grillet

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69394/#review210808
---


Ship it!




I will make the change marked above before committing.

- Kevin Klues


On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69394/
> ---
> 
> (Updated Nov. 19, 2018, 2:17 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated 'mesos task list' to only display running tasks.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 0536ccb29551400ce59713017c86eb5e858aeb5f 
>   src/python/cli_new/lib/cli/tests/task.py 
> f033b4a7663279c8a7c49ed86b3acdda45ceb107 
> 
> 
> Diff: https://reviews.apache.org/r/69394/diff/1/
> 
> 
> Testing
> ---
> 
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 7 tests in 19.845s
> 
> OK
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-22 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69394/#review210807
---




src/python/cli_new/lib/cli/tests/task.py
Line 189 (original), 189 (patched)


We should use `[-1]` here instead of `pop()`.


- Kevin Klues


On Nov. 19, 2018, 2:17 nachm., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69394/
> ---
> 
> (Updated Nov. 19, 2018, 2:17 nachm.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-9399
> https://issues.apache.org/jira/browse/MESOS-9399
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated 'mesos task list' to only display running tasks.
> 
> 
> Diffs
> -
> 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> 0536ccb29551400ce59713017c86eb5e858aeb5f 
>   src/python/cli_new/lib/cli/tests/task.py 
> f033b4a7663279c8a7c49ed86b3acdda45ceb107 
> 
> 
> Diff: https://reviews.apache.org/r/69394/diff/1/
> 
> 
> Testing
> ---
> 
> (mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
> Running the Mesos CLI unit tests
> 
> TestAgentPlugin
> test_list (cli.tests.agent.TestAgentPlugin) ... ok
> 
> TestInfrastructure
> test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
> test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok
> 
> TestTaskPlugin
> test_exec (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
> test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
> test_list (cli.tests.task.TestTaskPlugin) ... ok
> 
> --
> Ran 7 tests in 19.845s
> 
> OK
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Review Request 69394: Updated 'mesos task list' to only display running tasks.

2018-11-19 Thread Armand Grillet 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69394/
---

Review request for mesos and Kevin Klues.


Bugs: MESOS-9399
https://issues.apache.org/jira/browse/MESOS-9399


Repository: mesos


Description
---

Updated 'mesos task list' to only display running tasks.


Diffs
-

  src/python/cli_new/lib/cli/plugins/task/main.py 
0536ccb29551400ce59713017c86eb5e858aeb5f 
  src/python/cli_new/lib/cli/tests/task.py 
f033b4a7663279c8a7c49ed86b3acdda45ceb107 


Diff: https://reviews.apache.org/r/69394/diff/1/


Testing
---

(mesos-cli) ?  cli_new (MESOS-9399) ? mesos-cli-tests
Running the Mesos CLI unit tests

TestAgentPlugin
test_list (cli.tests.agent.TestAgentPlugin) ... ok

TestInfrastructure
test_capture_output (cli.tests.tests.TestInfrastructure) ... ok
test_launch_binaries (cli.tests.tests.TestInfrastructure) ... ok

TestTaskPlugin
test_exec (cli.tests.task.TestTaskPlugin) ... ok
test_exec_exit_status (cli.tests.task.TestTaskPlugin) ... ok
test_exec_interactive (cli.tests.task.TestTaskPlugin) ... ok
test_list (cli.tests.task.TestTaskPlugin) ... ok

--
Ran 7 tests in 19.845s

OK


Thanks,

Armand Grillet