Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-09 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211800
---


Ship it!




Ship It!

- Meng Zhu


On Jan. 8, 2019, 6:53 p.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 8, 2019, 6:53 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorized function matcher would sometimes match a retry of
> the agent registration authorization. To ensure the matcher only
> matches the appropriate CREATE_VOLUME operation, we now specify
> that the argument should have the CREATE_VOLUME action.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/2/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-09 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211787
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['69689']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2725/mesos-review-69689

Relevant logs:

- 
[mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2725/mesos-review-69689/logs/mesos-tests.log):

```
I0109 18:33:53.920020  7624 master.cpp:11159] Removing task 
bb709bc3-fb02-44ad-aad0-3af745cbcddf with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework 6c0e305e-b813-4541-a4b2-0c15c329e493- on 
agent 6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.923017  1924 master.cpp:1271] Agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net) disconnected
I0109 18:33:53.924015  1924 master.cpp:3274] Disconnecting agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.924015  1924 master.cpp:3293] Deactivating agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 at slave(464)@192.10.1.6:51973 
(windows-02.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0109 18:33:53.924015  6220 hierarchical.cpp:358] Removed framework 
6c0e305e-b813-4541-a4b2-0c15c329e493-
I0109 18:33:53.924015  6220 hierarchical.cpp:802] Agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0 deactivated
I0109 18:33:53.925010  2324 containerizer.cpp:2463] Destroying container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc in RUNNING state
I0109 18:33:53.926017  2324 containerizer.cpp:3130] Transitioning the state of 
container 01baeeb2-14a8-4dcb-a678-e39bcefc84fc from RUNNING to DESTROYING
I0109 [   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (682 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (700 ms total)

[--] Global test environment tear-down
[==] 1082 tests from 104 test cases ran. (498304 ms total)
[  PASSED  ] 1081 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 1 FAILED TEST
  YOU HAVE 231 DISABLED TESTS

18:33:53.926017  2324 launcher.cpp:161] Asked to destroy container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc
W0109 18:33:53.927011  7424 process.cpp:838] Failed to recv on socket 
WindowsFD::Type::SOCKET=2072 to peer '192.10.1.6:53768': IO failed with error 
code: The specified network name is no longer available.

W0109 18:33:53.928010  7424 process.cpp:1423] Failed to recv on socket 
WindowsFD::Type::SOCKET=1800 to peer '192.10.1.6:53767': IO failed with error 
code: The specified network name is no longer available.

I0109 18:33:54.016850  1924 containerizer.cpp:2969] Container 
01baeeb2-14a8-4dcb-a678-e39bcefc84fc has exited
I0109 18:33:54.044796  6104 master.cpp:] Master terminating
I0109 18:33:54.046785  2144 hierarchical.cpp:644] Removed agent 
6c0e305e-b813-4541-a4b2-0c15c329e493-S0
I0109 18:33:54.276785  7424 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On Jan. 9, 2019, 2:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 9, 2019, 2:53 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorized function matcher would sometimes match a retry of
> the agent registration authorization. To ensure the matcher only
> matches the appropriate CREATE_VOLUME operation, we now specify
> that the argument should have the CREATE_VOLUME action.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/2/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-08 Thread Benjamin Mahler 


> On Jan. 8, 2019, 12:01 a.m., Meng Zhu wrote:
> > Thanks for fixing this! Can you describe what made the test flaky and how 
> > the patch fixes the issue (similar to your comment in the code)?

Thanks for asking for this, I've updated the summary with an explanation of the 
issue and the fix


> On Jan. 8, 2019, 12:01 a.m., Meng Zhu wrote:
> > src/tests/master_tests.cpp
> > Lines 10336-10341 (patched)
> > 
> >
> > While we are here, can you pause the clock at the beginning and advance 
> > the clock to trigger the agent registration and etc.

I'm a little weary of tests all manually driving the agent registration (there 
should be a better abstraction for spinning up a test cluster that waits for it 
to get into the steady state automatically). Regardless, I took a different 
approach now based on matching appropriately.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211749
---


On Jan. 9, 2019, 2:53 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 9, 2019, 2:53 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The authorized function matcher would sometimes match a retry of
> the agent registration authorization. To ensure the matcher only
> matches the appropriate CREATE_VOLUME operation, we now specify
> that the argument should have the CREATE_VOLUME action.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/2/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-08 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/
---

(Updated Jan. 9, 2019, 2:53 a.m.)


Review request for mesos and Meng Zhu.


Changes
---

Took a different approach based on matching the right authorization call.


Bugs: MESOS-9495
https://issues.apache.org/jira/browse/MESOS-9495


Repository: mesos


Description (updated)
---

The authorized function matcher would sometimes match a retry of
the agent registration authorization. To ensure the matcher only
matches the appropriate CREATE_VOLUME operation, we now specify
that the argument should have the CREATE_VOLUME action.


Diffs (updated)
-

  src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 


Diff: https://reviews.apache.org/r/69689/diff/2/

Changes: https://reviews.apache.org/r/69689/diff/1-2/


Testing
---

Ran in repetition before (could trigger the failure) and after (no failures 
yet).


Thanks,

Benjamin Mahler

Re: Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-07 Thread Meng Zhu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/#review211749
---



Thanks for fixing this! Can you describe what made the test flaky and how the 
patch fixes the issue (similar to your comment in the code)?


src/tests/master_tests.cpp
Lines 10336-10341 (patched)


While we are here, can you pause the clock at the beginning and advance the 
clock to trigger the agent registration and etc.


- Meng Zhu


On Jan. 7, 2019, 10:52 a.m., Benjamin Mahler wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69689/
> ---
> 
> (Updated Jan. 7, 2019, 10:52 a.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Bugs: MESOS-9495
> https://issues.apache.org/jira/browse/MESOS-9495
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 
> 
> 
> Diff: https://reviews.apache.org/r/69689/diff/1/
> 
> 
> Testing
> ---
> 
> Ran in repetition before (could trigger the failure) and after (no failures 
> yet).
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>

Review Request 69689: Fixed a flaky master volume authorization failure test.

2019-01-07 Thread Benjamin Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69689/
---

Review request for mesos and Meng Zhu.


Bugs: MESOS-9495
https://issues.apache.org/jira/browse/MESOS-9495


Repository: mesos


Description
---

See summary.


Diffs
-

  src/tests/master_tests.cpp 51fcbe8d72fce1e56790d22ab7deced4fdb3bf0e 


Diff: https://reviews.apache.org/r/69689/diff/1/


Testing
---

Ran in repetition before (could trigger the failure) and after (no failures 
yet).


Thanks,

Benjamin Mahler