Re: Review Request 69786: Added agent capability for operation feedback on default resources.

2019-01-25 Thread Gastón Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69786/#review212351
---


Ship it!




Ship It!

- Gastón Kleiman


On Jan. 17, 2019, 6:30 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69786/
> ---
> 
> (Updated Jan. 17, 2019, 6:30 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9525
> https://issues.apache.org/jira/browse/MESOS-9525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent capability for operation feedback on default resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d 
>   include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb 
>   src/common/protobuf_utils.hpp f5294710cbdbcca34a6468ad418938f2fe4e3d15 
>   src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441deb 
>   src/slave/constants.cpp 103384c1d75792357623f55fca03f0d798305339 
>   src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0 
>   src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69786/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 69786: Added agent capability for operation feedback on default resources.

2019-01-17 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69786/#review212126
---



PASS: Mesos patch 69786 was successfully built and tested.

Reviews applied: `['69786']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2798/mesos-review-69786

- Mesos Reviewbot Windows


On Jan. 18, 2019, 2:30 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69786/
> ---
> 
> (Updated Jan. 18, 2019, 2:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9525
> https://issues.apache.org/jira/browse/MESOS-9525
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added agent capability for operation feedback on default resources.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d 
>   include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb 
>   src/common/protobuf_utils.hpp f5294710cbdbcca34a6468ad418938f2fe4e3d15 
>   src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441deb 
>   src/slave/constants.cpp 103384c1d75792357623f55fca03f0d798305339 
>   src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0 
>   src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 
>   src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 
> 
> 
> Diff: https://reviews.apache.org/r/69786/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 69786: Added agent capability for operation feedback on default resources.

2019-01-17 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69786/
---

Review request for mesos, Benno Evers and Gastón Kleiman.


Bugs: MESOS-9525
https://issues.apache.org/jira/browse/MESOS-9525


Repository: mesos


Description
---

Added agent capability for operation feedback on default resources.


Diffs
-

  include/mesos/mesos.proto 2ef6ba3aef67cf34227569948fd3ddc8dfd5879d 
  include/mesos/v1/mesos.proto 1a701da65f653fe4191f92ff1fb1436809b50acb 
  src/common/protobuf_utils.hpp f5294710cbdbcca34a6468ad418938f2fe4e3d15 
  src/common/protobuf_utils.cpp a0159fed8d325808c5e8519da06173441deb 
  src/slave/constants.cpp 103384c1d75792357623f55fca03f0d798305339 
  src/slave/flags.cpp 6bac8e1409f04d639204c45eda8a90c098e3dbd0 
  src/tests/master_tests.cpp 1f8da63aa313c4679c0d7a3934802af1474e8f28 
  src/tests/slave_tests.cpp dc711de96053ebecb6b71b98f14f22cb9b050c52 


Diff: https://reviews.apache.org/r/69786/diff/1/


Testing
---

`make check`


Thanks,

Greg Mann