Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-28 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/
---

(Updated Jan. 28, 2019, 3:25 p.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
---

Rebased.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

This protobuf message will be used by the agent to atomically checkpoint
resources and operations.


Diffs (updated)
-

  src/CMakeLists.txt 1564183b8c59d79ae378aecf7b6f1e25b9e9faf5 
  src/Makefile.am b8105c9f097d43a8ed8dff790d26dd9008c158ab 
  src/slave/state.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/69793/diff/4/

Changes: https://reviews.apache.org/r/69793/diff/3-4/


Testing
---

Current tests still pass.

Compiled new proto with both cmake and autotools.


Thanks,

Gastón Kleiman

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-25 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/#review212341
---


Ship it!




Ship It!

- Greg Mann


On Jan. 24, 2019, 10:36 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69793/
> ---
> 
> (Updated Jan. 24, 2019, 10:36 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This protobuf message will be used by the agent to atomically checkpoint
> resources and operations.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
>   src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
>   src/slave/state.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69793/diff/3/
> 
> 
> Testing
> ---
> 
> Current tests still pass.
> 
> Compiled new proto with both cmake and autotools.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-24 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/
---

(Updated Jan. 24, 2019, 2:36 p.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
---

Addressed feedback.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

This protobuf message will be used by the agent to atomically checkpoint
resources and operations.


Diffs (updated)
-

  src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
  src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
  src/slave/state.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/69793/diff/3/

Changes: https://reviews.apache.org/r/69793/diff/2-3/


Testing
---

Current tests still pass.

Compiled new proto with both cmake and autotools.


Thanks,

Gastón Kleiman

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-24 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/#review212286
---




src/slave/state.proto
Lines 25 (patched)


This comment seems insufficient, since this could also include some pending 
operations?


- Greg Mann


On Jan. 24, 2019, 12:16 a.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69793/
> ---
> 
> (Updated Jan. 24, 2019, 12:16 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This protobuf message will be used by the agent to atomically checkpoint
> resources and operations.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
>   src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
>   src/slave/state.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69793/diff/2/
> 
> 
> Testing
> ---
> 
> Current tests still pass.
> 
> Compiled new proto with both cmake and autotools.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-23 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/
---

(Updated Jan. 23, 2019, 4:16 p.m.)


Review request for mesos, Benno Evers and Greg Mann.


Changes
---

Renamed proto file.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

This protobuf message will be used by the agent to atomically checkpoint
resources and operations.


Diffs (updated)
-

  src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
  src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
  src/slave/state.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/69793/diff/2/

Changes: https://reviews.apache.org/r/69793/diff/1-2/


Testing
---

Current tests still pass.

Compiled new proto with both cmake and autotools.


Thanks,

Gastón Kleiman

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-23 Thread Gastón Kleiman 


> On Jan. 22, 2019, 2:55 p.m., Greg Mann wrote:
> > src/Makefile.am
> > Lines 980 (patched)
> > 
> >
> > Did we consider `slave/state.proto` for this filename? Sorry I can't 
> > recall :) WDYT?

I think we briefly chatted about it and thought that it would be nice to have a 
file where we can add in the future more messages that might be used by the 
agent but I am also 100% OK renaming the file to `slave/state.proto` =).


- Gastón


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/#review212205
---


On Jan. 18, 2019, 3 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69793/
> ---
> 
> (Updated Jan. 18, 2019, 3 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This protobuf message will be used by the agent to atomically checkpoint
> resources and operations.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
>   src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
>   src/slave/slave.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69793/diff/1/
> 
> 
> Testing
> ---
> 
> Current tests still pass.
> 
> Compiled new proto with both cmake and autotools.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Re: Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-22 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/#review212205
---




src/Makefile.am
Lines 980 (patched)


Did we consider `slave/state.proto` for this filename? Sorry I can't recall 
:) WDYT?


- Greg Mann


On Jan. 18, 2019, 11 p.m., Gastón Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69793/
> ---
> 
> (Updated Jan. 18, 2019, 11 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This protobuf message will be used by the agent to atomically checkpoint
> resources and operations.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
>   src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
>   src/slave/slave.proto PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/69793/diff/1/
> 
> 
> Testing
> ---
> 
> Current tests still pass.
> 
> Compiled new proto with both cmake and autotools.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>

Review Request 69793: Added the `ResourceState` agent protobuf message.

2019-01-18 Thread Gastón Kleiman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69793/
---

Review request for mesos, Benno Evers and Greg Mann.


Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356


Repository: mesos


Description
---

This protobuf message will be used by the agent to atomically checkpoint
resources and operations.


Diffs
-

  src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
  src/Makefile.am cd785255fcdf1302a8f9fa358039e5d1f200e132 
  src/slave/slave.proto PRE-CREATION 


Diff: https://reviews.apache.org/r/69793/diff/1/


Testing
---

Current tests still pass.

Compiled new proto with both cmake and autotools.


Thanks,

Gastón Kleiman